PART2: Make SignedSettings use proper Value types instead of string all around the place.

chrome/browser/automation/testing_automation_provider_chromeos.cc

Index: chrome/browser/automation/testing_automation_provider_chromeos.cc
diff --git a/chrome/browser/automation/testing_automation_provider_chromeos.cc b/chrome/browser/automation/testing_automation_provider_chromeos.cc
index b462e0ed9cc4bee0f4774436e5a59a2d586f58df..c5fb535ad63cf074b621ccf774251edd29b127a7 100644
--- a/chrome/browser/automation/testing_automation_provider_chromeos.cc
+++ b/chrome/browser/automation/testing_automation_provider_chromeos.cc
@@ -522,7 +522,7 @@ void TestingAutomationProvider::SetProxySettings(DictionaryValue* args,
                                                 IPC::Message* reply_message) {

[Mattias Nissler (ping if slow), 2011/10/07 11:02:57]

drive-by nit: indentation?

[pastarmovj, 2011/10/13 11:25:06]

Done.

   AutomationJSONReply reply(this, reply_message);
   std::string key;
-  Value* value;
+  base::Value* value;
   if (!args->GetString("key", &key) || !args->Get("value", &value)) {
     reply.SendError("Invalid or missing args.");
     return;
@@ -532,7 +532,7 @@ void TestingAutomationProvider::SetProxySettings(DictionaryValue* args,
   setting_path.append(key);
 
   // ProxyCrosSettingsProvider will own the Value* passed to Set().
-  chromeos::CrosSettings::Get()->Set(setting_path, value->DeepCopy());
+  chromeos::CrosSettings::Get()->Set(setting_path, *value);

[Mattias Nissler (ping if slow), 2011/10/07 11:02:57]

Either the code is wrong or the comment is wrong. I guess it's the comment.

[pastarmovj, 2011/10/13 11:25:06]

Comment is wrong the object is not owned by the provider therefore we only give
a ref.

   reply.SendSuccess(NULL);
 }