PART2: Make SignedSettings use proper Value types instead of string all around the place.

chrome/browser/automation/testing_automation_provider_chromeos.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/testing_automation_provider.h"
 
 #include "base/command_line.h"
 #include "base/i18n/time_formatting.h"
 #include "base/stringprintf.h"
 #include "base/time.h"
@@ skipping 501 matching lines @@
   for (size_t i = 0; i < arraysize(settings); ++i) {
     const Value* setting = GetProxySetting(settings[i]);
     if (setting)
       return_value->Set(settings[i], setting->DeepCopy());
   }
 
   AutomationJSONReply(this, reply_message).SendSuccess(return_value.get());
 }
 
 void TestingAutomationProvider::SetProxySettings(DictionaryValue* args,
                                                 IPC::Message* reply_message) {

[Mattias Nissler (ping if slow), 2011/10/07 11:02:57]

drive-by nit: indentation?

[pastarmovj, 2011/10/13 11:25:06]

Done.

   AutomationJSONReply reply(this, reply_message);
   std::string key;
-  Value* value;
+  base::Value* value;
   if (!args->GetString("key", &key) || !args->Get("value", &value)) {
     reply.SendError("Invalid or missing args.");
     return;
   }
 
   std::string setting_path = "cros.session.proxy.";
   setting_path.append(key);
 
   // ProxyCrosSettingsProvider will own the Value* passed to Set().
-  chromeos::CrosSettings::Get()->Set(setting_path, value->DeepCopy());
+  chromeos::CrosSettings::Get()->Set(setting_path, *value);

[Mattias Nissler (ping if slow), 2011/10/07 11:02:57]

Either the code is wrong or the comment is wrong. I guess it's the comment.

[pastarmovj, 2011/10/13 11:25:06]

Comment is wrong the object is not owned by the provider therefore we only give
a ref.

   reply.SendSuccess(NULL);
 }
 
 void TestingAutomationProvider::ConnectToWifiNetwork(
     DictionaryValue* args, IPC::Message* reply_message) {
   if (!EnsureCrosLibraryLoaded(this, reply_message))
     return;
 
   AutomationJSONReply reply(this, reply_message);
   std::string service_path, password;
@@ skipping 583 matching lines @@
 
   // Set up an observer (it will delete itself).
   take_photo_dialog->AddObserver(new PhotoCaptureObserver(
       this, reply_message));
 
   views::Widget* window = browser::CreateViewsWindow(
       browser->window()->GetNativeHandle(), take_photo_dialog);
   window->SetAlwaysOnTop(true);
   window->Show();
 }