Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: chrome/browser/chromeos/cros_settings.h

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments and rebased on a the current PART1 version. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros_settings.h
diff --git a/chrome/browser/chromeos/cros_settings.h b/chrome/browser/chromeos/cros_settings.h
index efa283f2d0f32d09a8d8c2d26e16de4611a18cbb..5411de2b1d53cb6ab82ec248683ea9088d183b2e 100644
--- a/chrome/browser/chromeos/cros_settings.h
+++ b/chrome/browser/chromeos/cros_settings.h
@@ -35,8 +35,7 @@ class CrosSettings : public base::NonThreadSafe {
static bool IsCrosSettings(const std::string& path);
// Sets |in_value| to given |path| in cros settings.
- // Note that this takes ownership of |in_value|.
- void Set(const std::string& path, base::Value* in_value);
+ void Set(const std::string& path, const base::Value& in_value);
// Fires system setting change notification.
// TODO(pastarmovj): Consider to remove this function from the public
@@ -61,6 +60,10 @@ class CrosSettings : public base::NonThreadSafe {
void SetDouble(const std::string& path, double in_value);
void SetString(const std::string& path, const std::string& in_value);
+ // Convenience functions for manipulating lists.
+ void AppendToList(const std::string& path, const base::Value& value);
+ void RemoveFromList(const std::string& path, const base::Value& value);
+
// These are convenience forms of Get(). The value will be retrieved
// and the return value will be true if the path is valid and the value at
// the end of the path can be returned in the form specified.

Powered by Google App Engine
This is Rietveld 408576698