Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: chrome/browser/automation/testing_automation_provider_chromeos.cc

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments and rebased on a the current PART1 version. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros_settings.h » ('j') | chrome/browser/chromeos/cros_settings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/testing_automation_provider_chromeos.cc
diff --git a/chrome/browser/automation/testing_automation_provider_chromeos.cc b/chrome/browser/automation/testing_automation_provider_chromeos.cc
index 764bf3c3c1a92a5193f1148010aa4f95738986a0..9e6d2e75d48df928b5492627ec00bb75fdceb9ae 100644
--- a/chrome/browser/automation/testing_automation_provider_chromeos.cc
+++ b/chrome/browser/automation/testing_automation_provider_chromeos.cc
@@ -519,10 +519,10 @@ void TestingAutomationProvider::GetProxySettings(DictionaryValue* args,
}
void TestingAutomationProvider::SetProxySettings(DictionaryValue* args,
- IPC::Message* reply_message) {
+ IPC::Message* reply_message) {
AutomationJSONReply reply(this, reply_message);
std::string key;
- Value* value;
+ base::Value* value;
if (!args->GetString("key", &key) || !args->Get("value", &value)) {
reply.SendError("Invalid or missing args.");
return;
@@ -531,8 +531,7 @@ void TestingAutomationProvider::SetProxySettings(DictionaryValue* args,
std::string setting_path = "cros.session.proxy.";
setting_path.append(key);
- // ProxyCrosSettingsProvider will own the Value* passed to Set().
- chromeos::CrosSettings::Get()->Set(setting_path, value->DeepCopy());
+ chromeos::CrosSettings::Get()->Set(setting_path, *value);
reply.SendSuccess(NULL);
}
« no previous file with comments | « no previous file | chrome/browser/chromeos/cros_settings.h » ('j') | chrome/browser/chromeos/cros_settings.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698