Issue 8086024: Revert 103459 - Disable the error reporting option for secured URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8086024: Revert 103459 - Disable the error reporting option for secured URL. (Closed)

Created:
9 years, 2 months ago by jonathan.backer

Modified:
9 years, 2 months ago

Reviewers:
MAD

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 103459 - Disable the error reporting option for secured URL. When there is a translate error, we should not let users report them because the report includes the sercured URL which would get compromised. BUG=98441 TEST=Make sure the option is always disabled for secured (httpS) urls, and always enabled otherwise... Review URL: http://codereview.chromium.org/8080007 TBR=mad@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103460

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
	M	chrome/browser/translate/options_menu_model.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
	M	chrome/browser/translate/translate_manager.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

MAD

9 years, 2 months ago (2011-09-30 14:59:04 UTC) #2

On 2011/09/30 14:54:24, jonathan.backer wrote:

Thanks!

LGTM...

I was wondering why drover was stuck... I guess we were both reverting at the
same time and yours got it...

Sorry about the breakage, I'll find a fix for this...

Expand Messages | Collapse Messages