Issue 8080007: Disable the error reporting option for secured URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8080007: Disable the error reporting option for secured URL. (Closed)

Created:
9 years, 2 months ago by MAD

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, jochen (gone - plz use gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Disable the error reporting option for secured URL. When there is a translate error, we should not let users report them because the report includes the sercured URL which would get compromised. BUG=98441 TEST=Make sure the option is always disabled for secured (httpS) urls, and always enabled otherwise... Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103459

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/translate/options_menu_model.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/translate/translate_manager.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/8080007/1

9 years, 2 months ago (2011-09-30 01:27:12 UTC) #3

commit-bot: I haz the power

9 years, 2 months ago (2011-09-30 04:26:27 UTC) #4

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 103421, job name
was 8080007-1 (retry) (retry) (retry) (retry).

Expand Messages | Collapse Messages