chrome/browser/ui/webui/ntp/new_tab_page_handler.h - Issue 8086002: Add metrics to help measure effects of installing default apps in a profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_page_handler.h

Issue 8086002: Add metrics to help measure effects of installing default apps in a profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.cc ('K') | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/webui/ntp/new_tab_page_handler.cc » ('j') | chrome/browser/ui/webui/ntp/new_tab_page_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/new_tab_page_handler.h

===================================================================

--- chrome/browser/ui/webui/ntp/new_tab_page_handler.h (revision 103269)

+++ chrome/browser/ui/webui/ntp/new_tab_page_handler.h (working copy)

@@ -19,6 +19,7 @@

virtual ~NewTabPageHandler() {}

// WebUIMessageHandler implementation.

+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;

virtual void RegisterMessages() OVERRIDE;

// Callback for "closePromo".

@@ -50,10 +51,11 @@

// group, and the rest of the bits are used for the page group ID (defined

// here).

enum {

- INDEX_MASK = (1 << 10) - 1,

- MOST_VISITED_PAGE_ID = 1 << 10,

- APPS_PAGE_ID = 2 << 10,

- BOOKMARKS_PAGE_ID = 3 << 10,

+ PAGE_ID_OFFSET = 10,

+ INDEX_MASK = (1 << PAGE_ID_OFFSET) - 1,

+ MOST_VISITED_PAGE_ID = 1 << PAGE_ID_OFFSET,

+ APPS_PAGE_ID = 2 << PAGE_ID_OFFSET,

+ BOOKMARKS_PAGE_ID = 3 << PAGE_ID_OFFSET,

};

DISALLOW_COPY_AND_ASSIGN(NewTabPageHandler);