Add metrics to help measure effects of installing default apps in a profile.

chrome/browser/ui/webui/ntp/new_tab_page_handler.cc

Index: chrome/browser/ui/webui/ntp/new_tab_page_handler.cc
===================================================================
--- chrome/browser/ui/webui/ntp/new_tab_page_handler.cc	(revision 103269)
+++ chrome/browser/ui/webui/ntp/new_tab_page_handler.cc	(working copy)
@@ -4,6 +4,9 @@
 
 #include "chrome/browser/ui/webui/ntp/new_tab_page_handler.h"
 
+#include "base/metrics/field_trial.h"
+#include "base/metrics/histogram.h"
+#include "chrome/browser/extensions/default_apps_trial.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service.h"
@@ -21,19 +24,38 @@
 static const char kNTP4IntroURL[] =
   "http://www.google.com/support/chrome/bin/answer.py?answer=95451";
 
+WebUIMessageHandler* NewTabPageHandler::Attach(WebUI* web_ui) {
+  // Record an open of the NTP with its default page type.
+  PrefService* prefs = Profile::FromWebUI(web_ui)->GetPrefs();
+  int shown_page_type = prefs->GetInteger(prefs::kNTPShownPage) >>
+      PAGE_ID_OFFSET;
+  UMA_HISTOGRAM_ENUMERATION("NtpHandler.AttachShownPageType",
+                            shown_page_type, 4);
+
+  static bool default_apps_trial_exists = base::FieldTrialList::TrialExists(
+        kDefaultAppsTrial_Name);

[csilv, 2011/09/29 18:32:04]

style nit: line 36 should be indented 4 spaces.  Please consider the following
alternative wrapping for readability:

static bool default_apps_trial_exists =
    base::FieldTrialList::TrialExists(kDefaultAppsTrial_Name);

[Roger Tawa OOO till Jul 10th, 2011/09/29 19:10:59]

Done.

+  if (default_apps_trial_exists) {
+    UMA_HISTOGRAM_ENUMERATION(base::FieldTrial::MakeName(
+        "NtpHandler.AttachShownPageType", kDefaultAppsTrial_Name),
+        shown_page_type, 4);
+  }
+
+  return WebUIMessageHandler::Attach(web_ui);
+}
+
 void NewTabPageHandler::RegisterMessages() {
-  web_ui_->RegisterMessageCallback("closePromo", NewCallback(
+  web_ui()->RegisterMessageCallback("closePromo", NewCallback(
       this, &NewTabPageHandler::HandleClosePromo));
-  web_ui_->RegisterMessageCallback("pageSelected", NewCallback(
+  web_ui()->RegisterMessageCallback("pageSelected", NewCallback(
       this, &NewTabPageHandler::HandlePageSelected));
-  web_ui_->RegisterMessageCallback("introMessageDismissed", NewCallback(
+  web_ui()->RegisterMessageCallback("introMessageDismissed", NewCallback(
       this, &NewTabPageHandler::HandleIntroMessageDismissed));
-  web_ui_->RegisterMessageCallback("introMessageSeen", NewCallback(
+  web_ui()->RegisterMessageCallback("introMessageSeen", NewCallback(
       this, &NewTabPageHandler::HandleIntroMessageSeen));
 }
 
 void NewTabPageHandler::HandleClosePromo(const ListValue* args) {
-  Profile::FromWebUI(web_ui_)->GetPrefs()->SetBoolean(prefs::kNTPPromoClosed,
+  Profile::FromWebUI(web_ui())->GetPrefs()->SetBoolean(prefs::kNTPPromoClosed,
                                                       true);
   NotificationService* service = NotificationService::current();
   service->Notify(chrome::NOTIFICATION_PROMO_RESOURCE_STATE_CHANGED,
@@ -50,17 +72,29 @@
   CHECK(args->GetDouble(1, &index_double));
   int index = static_cast<int>(index_double);
 
-  PrefService* prefs = Profile::FromWebUI(web_ui_)->GetPrefs();
+  PrefService* prefs = Profile::FromWebUI(web_ui())->GetPrefs();
   prefs->SetInteger(prefs::kNTPShownPage, page_id | index);
+
+  int shown_page_type = page_id >> PAGE_ID_OFFSET;
+  UMA_HISTOGRAM_ENUMERATION("NtpHandler.SelectedShownPageType",
+                            shown_page_type, 4);
+
+  static bool default_apps_trial_exists = base::FieldTrialList::TrialExists(
+        kDefaultAppsTrial_Name);

[csilv, 2011/09/29 18:32:04]

ditto above comment

[Roger Tawa OOO till Jul 10th, 2011/09/29 19:10:59]

Done.

+  if (default_apps_trial_exists) {
+    UMA_HISTOGRAM_ENUMERATION(base::FieldTrial::MakeName(
+        "NtpHandler.SelectedShownPageType", kDefaultAppsTrial_Name),
+        shown_page_type, 4);
+  }
 }

[csilv, 2011/09/29 18:32:04]

The above block is mostly a repeat of the contents of attach.  Might be worth
putting into a separate method that can be called from both places.

[Roger Tawa OOO till Jul 10th, 2011/09/29 19:10:59]

The way the UMA_HISTOGRAM_ENUMERATION macro works (creating a static variable)
that does not work.

 
 void NewTabPageHandler::HandleIntroMessageDismissed(const ListValue* args) {
-  PrefService* prefs = Profile::FromWebUI(web_ui_)->GetPrefs();
+  PrefService* prefs = Profile::FromWebUI(web_ui())->GetPrefs();
   prefs->SetInteger(prefs::kNTP4IntroDisplayCount, kIntroDisplayMax + 1);
 }
 
 void NewTabPageHandler::HandleIntroMessageSeen(const ListValue* args) {
-  PrefService* prefs = Profile::FromWebUI(web_ui_)->GetPrefs();
+  PrefService* prefs = Profile::FromWebUI(web_ui())->GetPrefs();
   int intro_displays = prefs->GetInteger(prefs::kNTP4IntroDisplayCount);
   prefs->SetInteger(prefs::kNTP4IntroDisplayCount, intro_displays + 1);
 }