Add support for showing NaCl 64-bit processes in Chrome's task manager and about:memory page

Add support for showing NaCl 64-bit processes in Chrome's task manager and about:memory page

BUG=37732
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41890

[jam, 2010-03-16 20:39:06]

lgtm with this nit

http://codereview.chromium.org/807005/diff/4001/5001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/807005/diff/4001/5001#newcode3187
chrome/app/generated_resources.grd:3187: Native Client broker
hmm, can you run this by someone on the UI team?  It seems that zero users will
understand what this means.

http://codereview.chromium.org/807005/diff/4001/5004
File chrome/browser/memory_details_win.cc (right):

http://codereview.chromium.org/807005/diff/4001/5004#newcode147
chrome/browser/memory_details_win.cc:147: if (index2 == CHROME_NACL_PROCESS)
nit: need brace brackets here and below

[gregoryd, 2010-03-16 20:56:11]

http://codereview.chromium.org/807005/diff/4001/5001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/807005/diff/4001/5001#newcode3187
chrome/app/generated_resources.grd:3187: Native Client broker
On 2010/03/16 20:39:06, John Abd-El-Malek wrote:
> hmm, can you run this by someone on the UI team?  It seems that zero users
will
> understand what this means.

Yes, I started to think about possible translations into other languages and
came to the same conclusion. I think "NaCl launcher" would be better - what do
you think?

http://codereview.chromium.org/807005/diff/4001/5004
File chrome/browser/memory_details_win.cc (right):

http://codereview.chromium.org/807005/diff/4001/5004#newcode147
chrome/browser/memory_details_win.cc:147: if (index2 == CHROME_NACL_PROCESS)
On 2010/03/16 20:39:06, John Abd-El-Malek wrote:
> nit: need brace brackets here and below

Done.

[jam, 2010-03-16 21:46:49]

On Tue, Mar 16, 2010 at 1:56 PM, <gregoryd@google.com> wrote:

>
> http://codereview.chromium.org/807005/diff/4001/5001
> File chrome/app/generated_resources.grd (right):
>
> http://codereview.chromium.org/807005/diff/4001/5001#newcode3187
> chrome/app/generated_resources.grd:3187: Native Client broker
> On 2010/03/16 20:39:06, John Abd-El-Malek wrote:
>
>> hmm, can you run this by someone on the UI team?  It seems that zero
>>
> users will
>
>> understand what this means.
>>
>
> Yes, I started to think about possible translations into other languages
> and came to the same conclusion. I think "NaCl launcher" would be better
> - what do you think?


That's better, but still best to check with Ben/Glen

>
>
> http://codereview.chromium.org/807005/diff/4001/5004
> File chrome/browser/memory_details_win.cc (right):
>
> http://codereview.chromium.org/807005/diff/4001/5004#newcode147
> chrome/browser/memory_details_win.cc:147: if (index2 ==
> CHROME_NACL_PROCESS)
> On 2010/03/16 20:39:06, John Abd-El-Malek wrote:
>
>> nit: need brace brackets here and below
>>
>
> Done.
>
>
> http://codereview.chromium.org/807005
>

[Glen Murphy, 2010-03-16 21:54:02]

>> Yes, I started to think about possible translations
>> into other languages and came to the same conclusion. 
>> I think "NaCl launcher" would be better
>> what do you think?
> 
> That's better, but still best to check with Ben/Glen

I am familiar with NaCl in the same way a savvy user might be (assume I've read
a few articles and maybe seen a presentation), and NaCl launcher (and broker)
both mean nothing to me.

Can you describe it in a sentence?

[gregoryd, 2010-03-16 21:59:29]

On Win64 NaCl in Chrome requires one more process to run correctly. This
process is technically the sandbox broker, and it is used to launch NaCl
loader processes in such a way so that they run in the sandbox. The broker
process is started when the first NaCl module is loaded and is terminated
when there are no more NaCl modules running.


On Tue, Mar 16, 2010 at 14:54, <glen@chromium.org> wrote:

> Yes, I started to think about possible translations
>>> into other languages and came to the same conclusion.
>>> I think "NaCl launcher" would be better
>>> what do you think?
>>>
>>
>  That's better, but still best to check with Ben/Glen
>>
>
> I am familiar with NaCl in the same way a savvy user might be (assume I've
> read
> a few articles and maybe seen a presentation), and NaCl launcher (and
> broker)
> both mean nothing to me.
>
> Can you describe it in a sentence?
>
>
> http://codereview.chromium.org/807005
>

[Glen Murphy, 2010-03-16 22:10:24]

Thanks!

I think 'NaCl sandbox manager' could work. 'NaCl sandbox' was my first choice,
but it's less correct and could get confused with our actual sandbox.

The desc for the string says it's a prefix, but there's no $1 so I'm assuming
it's just a standalone row, which gives you more room if you wanted to mention
that it was only for 64-bit systems (e.g. "NaCl Sandbox Manager (x64)").


> On Win64 NaCl in Chrome requires one more process to run
> correctly. This process is technically the sandbox broker, 
> and it is used to launch NaCl loader processes in such a 
> way so that they run in the sandbox. The broker process
> is started when the first NaCl module is loaded and is
> terminated when there are no more NaCl modules running.
> 
> 
> On Tue, Mar 16, 2010 at 14:54, <mailto:glen@chromium.org> wrote:
> 
> > Yes, I started to think about possible translations
> >>> into other languages and came to the same conclusion.
> >>> I think "NaCl launcher" would be better
> >>> what do you think?
> >>>
> >>
> >  That's better, but still best to check with Ben/Glen
> >>
> >
> > I am familiar with NaCl in the same way a savvy user might be (assume I've
> > read
> > a few articles and maybe seen a presentation), and NaCl launcher (and
> > broker)
> > both mean nothing to me.
> >
> > Can you describe it in a sentence?
> >
> >
> > http://codereview.chromium.org/807005
> >
>

[Glen Murphy, 2010-03-16 22:24:59]

To clarify, when I say 'NaCl', we should use whatever we use in the other rows -
if that's 'Native Client', then it should be 'Native Client Sandbox Manager'.


On 2010/03/16 22:10:24, Glen Murphy wrote:
> Thanks!
> 
> I think 'NaCl sandbox manager' could work. 'NaCl sandbox' was my first choice,
> but it's less correct and could get confused with our actual sandbox.
> 
> The desc for the string says it's a prefix, but there's no $1 so I'm assuming
> it's just a standalone row, which gives you more room if you wanted to mention
> that it was only for 64-bit systems (e.g. "NaCl Sandbox Manager (x64)").
> 
> 
> > On Win64 NaCl in Chrome requires one more process to run
> > correctly. This process is technically the sandbox broker, 
> > and it is used to launch NaCl loader processes in such a 
> > way so that they run in the sandbox. The broker process
> > is started when the first NaCl module is loaded and is
> > terminated when there are no more NaCl modules running.
> > 
> > 
> > On Tue, Mar 16, 2010 at 14:54, <mailto:glen@chromium.org> wrote:
> > 
> > > Yes, I started to think about possible translations
> > >>> into other languages and came to the same conclusion.
> > >>> I think "NaCl launcher" would be better
> > >>> what do you think?
> > >>>
> > >>
> > >  That's better, but still best to check with Ben/Glen
> > >>
> > >
> > > I am familiar with NaCl in the same way a savvy user might be (assume I've
> > > read
> > > a few articles and maybe seen a presentation), and NaCl launcher (and
> > > broker)
> > > both mean nothing to me.
> > >
> > > Can you describe it in a sentence?
> > >
> > >
> > > http://codereview.chromium.org/807005
> > >
> >

[gregoryd, 2010-03-16 22:27:45]

Great, thanks. I'll change the string to "Native Client Sandbox Manager".


On Tue, Mar 16, 2010 at 15:24, <glen@chromium.org> wrote:

> To clarify, when I say 'NaCl', we should use whatever we use in the other
> rows -
> if that's 'Native Client', then it should be 'Native Client Sandbox
> Manager'.
>
>
>
> On 2010/03/16 22:10:24, Glen Murphy wrote:
>
>> Thanks!
>>
>
>  I think 'NaCl sandbox manager' could work. 'NaCl sandbox' was my first
>> choice,
>> but it's less correct and could get confused with our actual sandbox.
>>
>
>  The desc for the string says it's a prefix, but there's no $1 so I'm
>> assuming
>> it's just a standalone row, which gives you more room if you wanted to
>> mention
>> that it was only for 64-bit systems (e.g. "NaCl Sandbox Manager (x64)").
>>
>
>
>  > On Win64 NaCl in Chrome requires one more process to run
>> > correctly. This process is technically the sandbox broker,
>> > and it is used to launch NaCl loader processes in such a
>> > way so that they run in the sandbox. The broker process
>> > is started when the first NaCl module is loaded and is
>> > terminated when there are no more NaCl modules running.
>> >
>> >
>> > On Tue, Mar 16, 2010 at 14:54, <mailto:glen@chromium.org> wrote:
>> >
>> > > Yes, I started to think about possible translations
>> > >>> into other languages and came to the same conclusion.
>> > >>> I think "NaCl launcher" would be better
>> > >>> what do you think?
>> > >>>
>> > >>
>> > >  That's better, but still best to check with Ben/Glen
>> > >>
>> > >
>> > > I am familiar with NaCl in the same way a savvy user might be (assume
>> I've
>> > > read
>> > > a few articles and maybe seen a presentation), and NaCl launcher (and
>> > > broker)
>> > > both mean nothing to me.
>> > >
>> > > Can you describe it in a sentence?
>> > >
>> > >
>> > > http://codereview.chromium.org/807005
>> > >
>> >
>>
>
>
>
> http://codereview.chromium.org/807005
>