Don't allow Chrome to go into background mode when launched by GCF.

Don't allow Chrome to go into background mode when launched by GCF.

Doing so is broken in at least a few ways:
- in-use updates don't work as desired (must quit IE for 6h)
- there's no UX for quitting Chrome

Since extensions aren't really supported in GCF anyway, I don't see a problem with disallowing background mode.

BUG=97740
TEST=the easy way: fire up IE and visit gcf:about:version, confirm that --disable-background-mode is on the command line.  the hard way: install a background extension via the registry mechanism then launch IE and visit gcf:about:version.  now check to see if you have an extension process.  if so, see that quitting IE makes all chrome.exe processes disappear.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103277

[robertshield, 2011-09-29 03:47:23]

LGTM

http://codereview.chromium.org/8070019/diff/1/chrome_frame/chrome_launcher_un...
File chrome_frame/chrome_launcher_unittest.cc (right):

http://codereview.chromium.org/8070019/diff/1/chrome_frame/chrome_launcher_un...
chrome_frame/chrome_launcher_unittest.cc:65:
EXPECT_TRUE(chrome_launcher::IsValidArgument(L"--disable-background-mode"));
nit: move this up to under line 58, since this is testing a valid flag name, not
a flag name variant

[grt (UTC plus 2), 2011-09-29 13:07:31]

gracias

http://codereview.chromium.org/8070019/diff/1/chrome_frame/chrome_launcher_un...
File chrome_frame/chrome_launcher_unittest.cc (right):

http://codereview.chromium.org/8070019/diff/1/chrome_frame/chrome_launcher_un...
chrome_frame/chrome_launcher_unittest.cc:65:
EXPECT_TRUE(chrome_launcher::IsValidArgument(L"--disable-background-mode"));
On 2011/09/29 03:47:24, robertshield wrote:
> nit: move this up to under line 58, since this is testing a valid flag name,
not
> a flag name variant

Done.

[commit-bot: I haz the power, 2011-09-29 13:07:40]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/8070019/4001

[commit-bot: I haz the power, 2011-09-29 15:12:48]

Change committed as 103277