Don't allow Chrome to go into background mode when launched by GCF.

chrome_frame/chrome_launcher_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome_frame/chrome_launcher.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 TEST(ChromeLauncher, IsValidCommandLine) {
   CommandLine bad(FilePath(L"dummy.exe"));
   bad.AppendSwitch(switches::kNoFirstRun);  // in whitelist
   bad.AppendSwitch("no-such-switch");  // does not exist
   bad.AppendSwitch(switches::kHomePage);  // exists but not in whitelist
 
   EXPECT_FALSE(chrome_launcher::IsValidCommandLine(
       bad.GetCommandLineString().c_str()));
 
   CommandLine good(FilePath(L"dummy.exe"));
   good.AppendSwitch(switches::kNoFirstRun);  // in whitelist
+  good.AppendSwitch(switches::kDisableBackgroundMode);  // in whitelist
   good.AppendSwitchASCII(switches::kUserDataDir, "foo");  // in whitelist
 
   EXPECT_TRUE(chrome_launcher::IsValidCommandLine(
       good.GetCommandLineString().c_str()));
 
   CommandLine no_params(FilePath(L"dummy.exe"));
   EXPECT_TRUE(chrome_launcher::IsValidCommandLine(
       no_params.GetCommandLineString().c_str()));
 
   CommandLine empty(FilePath(L""));
@@ skipping 22 matching lines @@
 }
 
 TEST(ChromeLauncher, IsValidArgument) {
   EXPECT_TRUE(chrome_launcher::IsValidArgument(L"--chrome-frame"));
   EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--invalid-arg"));
 
   EXPECT_TRUE(chrome_launcher::IsValidArgument(L"--chrome-frame="));
   EXPECT_TRUE(chrome_launcher::IsValidArgument(L"--chrome-frame=foo"));
   EXPECT_TRUE(chrome_launcher::IsValidArgument(L"--chrome-frame=foo=foo"));
 
+  EXPECT_TRUE(chrome_launcher::IsValidArgument(L"--disable-background-mode"));

[robertshield, 2011/09/29 03:47:24]

nit: move this up to under line 58, since this is testing a valid flag name, not
a flag name variant

[grt (UTC plus 2), 2011/09/29 13:07:31]

Done.

+
   EXPECT_FALSE(chrome_launcher::IsValidArgument(L"chrome-frame"));
   EXPECT_FALSE(chrome_launcher::IsValidArgument(L"-chrome-frame"));
   EXPECT_FALSE(chrome_launcher::IsValidArgument(L"---chrome-frame"));
   EXPECT_FALSE(chrome_launcher::IsValidArgument(L" --chrome-frame"));
   EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-framefoobar"));
   EXPECT_FALSE(chrome_launcher::IsValidArgument(L"foobar--chrome-frame"));
   EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--chrome-frames"));
   EXPECT_FALSE(chrome_launcher::IsValidArgument(L"--Chrome-frame"));
   EXPECT_FALSE(chrome_launcher::IsValidArgument(L""));
 }