Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 8068024: Simplify compares in KeyedStoreIC::GenerateGeneric. (Closed)

Created:
9 years, 2 months ago by Yang
Modified:
9 years, 2 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Simplify compares in KeyedStoreIC::GenerateGeneric. Committed: http://code.google.com/p/v8/source/detail?r=9514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M src/arm/ic-arm.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/ia32/ic-ia32.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/x64/ic-x64.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
Please take a look.
9 years, 2 months ago (2011-09-29 07:46:36 UTC) #1
rossberg
9 years, 2 months ago (2011-10-04 09:04:25 UTC) #2
Oops, thanks, I forgot to remove that temporary implementation after I merged in
the instance type reorg change.

LGTM

Powered by Google App Engine
This is Rietveld 408576698