Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Side by Side Diff: src/arm/ic-arm.cc

Issue 8068024: Simplify compares in KeyedStoreIC::GenerateGeneric. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/ic-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1279 matching lines...) Expand 10 before | Expand all | Expand 10 after
1290 // Check that the receiver does not require access checks. We need 1290 // Check that the receiver does not require access checks. We need
1291 // to do this because this generic stub does not perform map checks. 1291 // to do this because this generic stub does not perform map checks.
1292 __ ldrb(ip, FieldMemOperand(r4, Map::kBitFieldOffset)); 1292 __ ldrb(ip, FieldMemOperand(r4, Map::kBitFieldOffset));
1293 __ tst(ip, Operand(1 << Map::kIsAccessCheckNeeded)); 1293 __ tst(ip, Operand(1 << Map::kIsAccessCheckNeeded));
1294 __ b(ne, &slow); 1294 __ b(ne, &slow);
1295 // Check if the object is a JS array or not. 1295 // Check if the object is a JS array or not.
1296 __ ldrb(r4, FieldMemOperand(r4, Map::kInstanceTypeOffset)); 1296 __ ldrb(r4, FieldMemOperand(r4, Map::kInstanceTypeOffset));
1297 __ cmp(r4, Operand(JS_ARRAY_TYPE)); 1297 __ cmp(r4, Operand(JS_ARRAY_TYPE));
1298 __ b(eq, &array); 1298 __ b(eq, &array);
1299 // Check that the object is some kind of JSObject. 1299 // Check that the object is some kind of JSObject.
1300 __ cmp(r4, Operand(FIRST_JS_RECEIVER_TYPE)); 1300 __ cmp(r4, Operand(FIRST_JS_OBJECT_TYPE));
1301 __ b(lt, &slow); 1301 __ b(lt, &slow);
1302 __ cmp(r4, Operand(JS_PROXY_TYPE));
1303 __ b(eq, &slow);
1304 __ cmp(r4, Operand(JS_FUNCTION_PROXY_TYPE));
1305 __ b(eq, &slow);
1306 1302
1307 // Object case: Check key against length in the elements array. 1303 // Object case: Check key against length in the elements array.
1308 __ ldr(elements, FieldMemOperand(receiver, JSObject::kElementsOffset)); 1304 __ ldr(elements, FieldMemOperand(receiver, JSObject::kElementsOffset));
1309 // Check that the object is in fast mode and writable. 1305 // Check that the object is in fast mode and writable.
1310 __ ldr(r4, FieldMemOperand(elements, HeapObject::kMapOffset)); 1306 __ ldr(r4, FieldMemOperand(elements, HeapObject::kMapOffset));
1311 __ LoadRoot(ip, Heap::kFixedArrayMapRootIndex); 1307 __ LoadRoot(ip, Heap::kFixedArrayMapRootIndex);
1312 __ cmp(r4, ip); 1308 __ cmp(r4, ip);
1313 __ b(ne, &slow); 1309 __ b(ne, &slow);
1314 // Check array bounds. Both the key and the length of FixedArray are smis. 1310 // Check array bounds. Both the key and the length of FixedArray are smis.
1315 __ ldr(ip, FieldMemOperand(elements, FixedArray::kLengthOffset)); 1311 __ ldr(ip, FieldMemOperand(elements, FixedArray::kLengthOffset));
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
1641 Register reg = Assembler::GetRn(instr_at_patch); 1637 Register reg = Assembler::GetRn(instr_at_patch);
1642 patcher.masm()->tst(reg, Operand(kSmiTagMask)); 1638 patcher.masm()->tst(reg, Operand(kSmiTagMask));
1643 patcher.EmitCondition(eq); 1639 patcher.EmitCondition(eq);
1644 } 1640 }
1645 } 1641 }
1646 1642
1647 1643
1648 } } // namespace v8::internal 1644 } } // namespace v8::internal
1649 1645
1650 #endif // V8_TARGET_ARCH_ARM 1646 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698