Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2245)

Unified Diff: chrome/browser/sync/profile_sync_factory_impl.h

Issue 8065016: [Sync] Refactor non-frontend DTC to handle new API properly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self review Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_factory_impl.h
diff --git a/chrome/browser/sync/profile_sync_factory_impl.h b/chrome/browser/sync/profile_sync_factory_impl.h
index 5d8873bcd11bf41ff9788557a96dab4b0a1e4da6..56ca35c03be2eb469aff96d1f73d7ce29ba9ff33 100644
--- a/chrome/browser/sync/profile_sync_factory_impl.h
+++ b/chrome/browser/sync/profile_sync_factory_impl.h
@@ -30,6 +30,13 @@ class ProfileSyncFactoryImpl : public ProfileSyncFactory {
browser_sync::SyncBackendHost* backend,
const browser_sync::DataTypeController::TypeMap* controllers);
+ virtual browser_sync::GenericChangeProcessor* CreateGenericChangeProcessor(
akalin 2011/10/13 00:08:16 add comment about this being here for testing
Nicolas Zea 2011/10/13 01:16:14 Done (added to base header).
+ ProfileSyncService* profile_sync_service,
+ browser_sync::UnrecoverableErrorHandler* error_handler,
+ const base::WeakPtr<SyncableService>& local_service);
+
+ virtual browser_sync::SharedChangeProcessor* CreateSharedChangeProcessor();
+
virtual SyncComponents CreateAppSyncComponents(
ProfileSyncService* profile_sync_service,
browser_sync::UnrecoverableErrorHandler* error_handler);
@@ -39,10 +46,8 @@ class ProfileSyncFactoryImpl : public ProfileSyncFactory {
WebDatabase* web_database,
browser_sync::UnrecoverableErrorHandler* error_handler);
- virtual SyncComponents CreateAutofillProfileSyncComponents(
- ProfileSyncService* profile_sync_service,
- WebDataService* web_data_service,
- browser_sync::UnrecoverableErrorHandler* error_handler);
+ virtual base::WeakPtr<SyncableService> GetAutofillProfileSyncableService(
+ WebDataService* web_data_service);
akalin 2011/10/13 00:08:16 make this fn const? I notice some of the other fu
Nicolas Zea 2011/10/13 01:16:14 Done.
virtual SyncComponents CreateBookmarkSyncComponents(
ProfileSyncService* profile_sync_service,

Powered by Google App Engine
This is Rietveld 408576698