Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2820)

Unified Diff: chrome/browser/sync/profile_sync_factory.h

Issue 8065016: [Sync] Refactor non-frontend DTC to handle new API properly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self review Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_factory.h
diff --git a/chrome/browser/sync/profile_sync_factory.h b/chrome/browser/sync/profile_sync_factory.h
index 5b652b0630886f9e1aac386e842b369d727d0c56..1d1ff8a7c22fcf3989a23f92e37d88e47cb8250d 100644
--- a/chrome/browser/sync/profile_sync_factory.h
+++ b/chrome/browser/sync/profile_sync_factory.h
@@ -19,11 +19,14 @@ class ExtensionSettingsBackend;
class PasswordStore;
class PersonalDataManager;
class ProfileSyncService;
+class SyncableService;
class WebDatabase;
class WebDataService;
namespace browser_sync {
class DataTypeManager;
+class GenericChangeProcessor;
+class SharedChangeProcessor;
class SyncBackendHost;
class UnrecoverableErrorHandler;
}
@@ -39,6 +42,15 @@ class ProfileSyncFactory {
// and change processors all return this struct. This is needed
// because the change processors typically require a type-specific
// model associator at construction time.
+ //
+ // Note: This interface is deprecated in favor of the SyncableService API.
+ // New datatypes that do not live on the UI thread should directly return a
+ // weak pointer to a SyncableService. All others continue to return
+ // SyncComponents. It is safe to assume that the factory methods below are
+ // called on the same thread in which the datatype resides.
+ //
+ // TODO(zea): Have all datatypes using the new API switch to returning
+ // SyncableService weak pointers instead of SyncComponents (crbug.com/100114).
struct SyncComponents {
browser_sync::AssociatorInterface* model_associator;
browser_sync::ChangeProcessor* change_processor;
@@ -65,6 +77,14 @@ class ProfileSyncFactory {
browser_sync::SyncBackendHost* backend,
const browser_sync::DataTypeController::TypeMap* controllers) = 0;
+ virtual browser_sync::GenericChangeProcessor* CreateGenericChangeProcessor(
+ ProfileSyncService* profile_sync_service,
+ browser_sync::UnrecoverableErrorHandler* error_handler,
+ const base::WeakPtr<SyncableService>& local_service) = 0;
+
+ virtual browser_sync::SharedChangeProcessor*
+ CreateSharedChangeProcessor() = 0;
+
// Instantiates both a model associator and change processor for the
// app data type. The pointers in the return struct are
// owned by the caller.
@@ -80,13 +100,11 @@ class ProfileSyncFactory {
WebDatabase* web_database,
browser_sync::UnrecoverableErrorHandler* error_handler) = 0;
- // Instantiates both a model associator and change processor for the
- // autofill data type. The pointers in the return struct are owned
- // by the caller.
- virtual SyncComponents CreateAutofillProfileSyncComponents(
- ProfileSyncService* profile_sync_service,
- WebDataService* web_data_service,
- browser_sync::UnrecoverableErrorHandler* error_handler) = 0;
+ // Returns a weak pointer to the SyncableService associated with the datatype.
+ // The SyncableService is not owned by Sync, but by the backend service
+ // itself.
+ virtual base::WeakPtr<SyncableService> GetAutofillProfileSyncableService(
+ WebDataService* web_data_service) = 0;
// Instantiates both a model associator and change processor for the
// bookmark data type. The pointers in the return struct are owned

Powered by Google App Engine
This is Rietveld 408576698