[Sync] Refactor non-frontend DTC to handle new API properly.

chrome/browser/sync/glue/app_data_type_controller.h

Index: chrome/browser/sync/glue/app_data_type_controller.h
diff --git a/chrome/browser/sync/glue/app_data_type_controller.h b/chrome/browser/sync/glue/app_data_type_controller.h
index 93bd51799ce24d9341b23e570b035e4e567a6215..e86aeb579286a35ad88e87131b7cc687aaa2f301 100644
--- a/chrome/browser/sync/glue/app_data_type_controller.h
+++ b/chrome/browser/sync/glue/app_data_type_controller.h
@@ -12,6 +12,8 @@
 
 namespace browser_sync {
 
+class GenericChangeProcessor;

[akalin, 2011/10/12 19:54:21]

Apply all comments to this class to the other DTCs

[Nicolas Zea, 2011/10/12 23:47:43]

Done.

+
 class AppDataTypeController : public FrontendDataTypeController {
  public:
   AppDataTypeController(
@@ -23,6 +25,9 @@ class AppDataTypeController : public FrontendDataTypeController {
   // DataTypeController implementation.
   virtual syncable::ModelType type() const;
 
+ protected:
+  virtual ChangeProcessor* change_processor() const OVERRIDE;

[akalin, 2011/10/12 19:54:21]

may as well have this return GenericChangeProcessor* (C++ has covariant return
types, so the override still happens)

[Nicolas Zea, 2011/10/12 23:47:43]

Done.

+
  private:
   // DataTypeController implementations.
   virtual bool StartModels();
@@ -33,6 +38,8 @@ class AppDataTypeController : public FrontendDataTypeController {
   virtual void RecordAssociationTime(base::TimeDelta time);
   virtual void RecordStartFailure(StartResult result);
 
+  scoped_ptr<GenericChangeProcessor> change_processor_;

[akalin, 2011/10/12 19:54:21]

wait, doesn't this shadow change_processor_ in FrontendDataTypeController?  Can
we remove the variable from FrontendDataTypeController?

[Nicolas Zea, 2011/10/12 23:47:43]

It does, but we can't get rid of it in FrontendDTC yet because there are still
some FE datatypes that aren't using the new API. This is a stopgap until all
SyncableService's take ownership of their change processors and until I create a
new FEDTC just for the new api datatypes.

[akalin, 2011/10/13 00:08:16]

I see.  Can you rename it so that it's not confusing, maybe
generic_change_processor_?

+
   DISALLOW_COPY_AND_ASSIGN(AppDataTypeController);
 };