[Sync] Refactor non-frontend DTC to handle new API properly.

chrome/browser/sync/glue/app_data_type_controller.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_APP_DATA_TYPE_CONTROLLER_H_
 #define CHROME_BROWSER_SYNC_GLUE_APP_DATA_TYPE_CONTROLLER_H_
 #pragma once
 
 #include <string>
 
 #include "chrome/browser/sync/glue/frontend_data_type_controller.h"
 
 namespace browser_sync {
 
+class GenericChangeProcessor;

[akalin, 2011/10/12 19:54:21]

Apply all comments to this class to the other DTCs

[Nicolas Zea, 2011/10/12 23:47:43]

Done.

+
 class AppDataTypeController : public FrontendDataTypeController {
  public:
   AppDataTypeController(
       ProfileSyncFactory* profile_sync_factory,
       Profile* profile,
       ProfileSyncService* sync_service);
   virtual ~AppDataTypeController();
 
   // DataTypeController implementation.
   virtual syncable::ModelType type() const;
 
+ protected:
+  virtual ChangeProcessor* change_processor() const OVERRIDE;

[akalin, 2011/10/12 19:54:21]

may as well have this return GenericChangeProcessor* (C++ has covariant return
types, so the override still happens)

[Nicolas Zea, 2011/10/12 23:47:43]

Done.

+
  private:
   // DataTypeController implementations.
   virtual bool StartModels();
   virtual void CreateSyncComponents();
   virtual void RecordUnrecoverableError(
       const tracked_objects::Location& from_here,
       const std::string& message);
   virtual void RecordAssociationTime(base::TimeDelta time);
   virtual void RecordStartFailure(StartResult result);
 
+  scoped_ptr<GenericChangeProcessor> change_processor_;

[akalin, 2011/10/12 19:54:21]

wait, doesn't this shadow change_processor_ in FrontendDataTypeController?  Can
we remove the variable from FrontendDataTypeController?

[Nicolas Zea, 2011/10/12 23:47:43]

It does, but we can't get rid of it in FrontendDTC yet because there are still
some FE datatypes that aren't using the new API. This is a stopgap until all
SyncableService's take ownership of their change processors and until I create a
new FEDTC just for the new api datatypes.

[akalin, 2011/10/13 00:08:16]

I see.  Can you rename it so that it's not confusing, maybe
generic_change_processor_?

+
   DISALLOW_COPY_AND_ASSIGN(AppDataTypeController);
 };
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_APP_DATA_TYPE_CONTROLLER_H_