Issue 8059034: Reland 103021: Printing preview of a PDF on Mac with Skia only previews the last page of the PDF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8059034: Reland 103021: Printing preview of a PDF on Mac with Skia only previews the last page of the PDF (Closed)

Created:
9 years, 2 months ago by kmadhusu

Modified:
9 years, 2 months ago

Reviewers:
vandebo (ex-Chrome), commit-bot: I haz the power

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Reland 103021: Printing preview of a PDF on Mac with Skia only previews the last page of the PDF BUG=93145 TEST=Please refer to bug report. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103021 Original review URL: codereview.chromium.org/7719014 Please refer to trybot results in the last patch of original review url. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103082

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -65 lines)			Patch
M	chrome/renderer/print_web_view_helper.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/renderer/print_web_view_helper_linux.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_mac.mm	View	5 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper_win.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	printing/metafile_skia_wrapper.h	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	printing/metafile_skia_wrapper.cc	View	3 chunks	+5 lines, -29 lines	0 comments	Download
M	skia/ext/platform_device.h	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	skia/ext/platform_device.cc	View	3 chunks	+45 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.h	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	5 chunks	+14 lines, -9 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/8059034/1

9 years, 2 months ago (2011-09-28 00:25:54 UTC) #3

Change committed as 103082