Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.h

Issue 8059034: Reland 103021: Printing preview of a PDF on Mac with Skia only previews the last page of the PDF (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/ext/platform_device.cc ('k') | webkit/plugins/ppapi/ppapi_plugin_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppapi_plugin_instance.h
diff --git a/webkit/plugins/ppapi/ppapi_plugin_instance.h b/webkit/plugins/ppapi/ppapi_plugin_instance.h
index f46301b1bcdc8a1bd767ba21987b640fa176d207..fdb3dcea7d87d4924f8af9eccd36e91f5ae17bf2 100644
--- a/webkit/plugins/ppapi/ppapi_plugin_instance.h
+++ b/webkit/plugins/ppapi/ppapi_plugin_instance.h
@@ -466,14 +466,14 @@ class PluginInstance : public base::RefCounted<PluginInstance>,
// variable to hold on to the pixels.
scoped_refptr<PPB_ImageData_Impl> last_printed_page_;
#endif // defined(OS_MACOSX)
-#if defined(OS_LINUX) || defined(OS_WIN)
- // When printing to PDF (print preview, Linux) the entire document goes into
- // one metafile. However, when users print only a subset of all the pages,
- // it is impossible to know if a call to PrintPage() is the last call.
- // Thus in PrintPage(), just store the page number in |ranges_|.
- // The hack is in PrintEnd(), where a valid |canvas_| is preserved in
- // PrintWebViewHelper::PrintPages. This makes it possible to generate the
- // entire PDF given the variables below:
+#if defined(USE_SKIA)
+ // Always when printing to PDF on Linux and when printing for preview on Mac
+ // and Win, the entire document goes into one metafile. However, when users
+ // print only a subset of all the pages, it is impossible to know if a call
+ // to PrintPage() is the last call. Thus in PrintPage(), just store the page
+ // number in |ranges_|. The hack is in PrintEnd(), where a valid |canvas_|
+ // is preserved in PrintWebViewHelper::PrintPages. This makes it possible
+ // to generate the entire PDF given the variables below:
//
// The most recently used WebCanvas, guaranteed to be valid.
SkRefPtr<WebKit::WebCanvas> canvas_;
« no previous file with comments | « skia/ext/platform_device.cc ('k') | webkit/plugins/ppapi/ppapi_plugin_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698