Issue 8056008: Disable ppapi_bad test for glibc on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8056008: Disable ppapi_bad test for glibc on Windows. (Closed)

Created:
9 years, 2 months ago by dmichael (off chromium)

Modified:
9 years, 2 months ago

Reviewers:
Nick Bray

CC:
chromium-reviews, halyavin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Disable ppapi_bad test for glibc on Windows. This test is timing out on Windows 7 and blocking a DEPS roll. This CL partly undoes the following CL which enabled the test everywhere for glibc: http://codereview.chromium.org/7979018 The failure is currently visible on the Win7 chrome integration bot: http://chromegw.corp.google.com/i/client.nacl.chrome/builders/win7-nacl-chrome-test http://chromegw.corp.google.com/i/client.nacl.chrome/console BUG= http://code.google.com/p/nativeclient/issues/detail?id=2191 TEST=run ./scons --mode=dbg-host,nacl platform=x86-64 --nacl_glibc run_ppapi_bad_browser_test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102986

Patch Set 1 : fix parens #

Total comments: 1

Patch Set 2 : add comment linking to bug #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	ppapi/native_client/tests/ppapi_browser/bad/nacl.scons	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nick Bray

9 years, 2 months ago (2011-09-27 17:05:42 UTC) #2

LGTM w/ comment.

http://codereview.chromium.org/8056008/diff/2001/ppapi/native_client/tests/pp...
File ppapi/native_client/tests/ppapi_browser/bad/nacl.scons (right):

http://codereview.chromium.org/8056008/diff/2001/ppapi/native_client/tests/pp...
ppapi/native_client/tests/ppapi_browser/bad/nacl.scons:72:
(env.Bit('nacl_glibc') and env.Bit('windows')))
Please stick a comment in the code linking to the issue.

Expand Messages | Collapse Messages