Issue 7979018: Enable working part of ppapi_bad test with NaCl glibc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7979018: Enable working part of ppapi_bad test with NaCl glibc. (Closed)

Created:
9 years, 3 months ago by halyavin

Modified:
9 years, 3 months ago

Reviewers:
Nick Bray, noelallen1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Enable working part of ppapi_bad test with NaCl glibc. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2191 TEST= run ./scons --mode=dbg-host,nacl platform=x86-64 --nacl_glibc run_ppapi_bad_browser_test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102250

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	ppapi/native_client/tests/ppapi_browser/bad/nacl.scons	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Nick Bray

9 years, 3 months ago (2011-09-21 20:41:25 UTC) #2

LGTM, but that may not be enough.  (Apparently I am still only a provisional
committer, not a "real" committer.)

Looping in Noel.