Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 8055036: Revert 103010 - Refactored code to move cloudprint specific code into print_preview_cloud.js. (Closed)

Created:
9 years, 2 months ago by Lei Zhang
Modified:
9 years, 2 months ago
Reviewers:
abodenha
CC:
chromium-reviews, arv (Not doing code reviews), Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 103010 - Refactored code to move cloudprint specific code into print_preview_cloud.js. Removed "Local" and "Cloud" labels from dropdown The "More printers" label is now more clear and shares behavior with the cloud print printer option in Chrome. The system print dialog link is replaced with a similar link referencing cloud print in chrome os. Choosing cloud print from the printers dropdown now requires the user to hit print before opening the cloud print dialog. Fixed broken tests. BUG=88098, 97175 , http://code.google.com/p/chromium-os/issues/detail?id=16082, http://code.google.com/p/chromium-os/issues/detail?id=20121, http://code.google.com/p/chromium-os/issues/detail?id=20119 TEST=Enable print preview in about:flags. Printing should work with cloud print printers in much the same way as local printers in Chrome Review URL: http://codereview.chromium.org/7976017 TBR=abodenha@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -167 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +18 lines, -9 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.html View 1 chunk +2 lines, -8 lines 0 comments Download
chrome/browser/resources/print_preview/print_preview.js View 13 chunks +159 lines, -27 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview_cloud.js View 3 chunks +6 lines, -85 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_data_source.cc View 1 chunk +9 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/test/data/webui/print_preview.js View 1 chunk +22 lines, -16 lines 0 comments Download
M printing/print_job_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M printing/print_job_constants.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
9 years, 2 months ago (2011-09-28 01:04:44 UTC) #1
Lei Zhang
I tried to print using print preview to a local printer, and I got a ...
9 years, 2 months ago (2011-09-28 01:06:04 UTC) #2
abodenha
9 years, 2 months ago (2011-09-28 01:12:43 UTC) #3
Lgtm
On Sep 27, 2011 6:06 PM, <thestig@chromium.org> wrote:

> I tried to print using print preview to a local printer, and I got a CP
> dialog
> asking me to login.
>
>
http://codereview.chromium.**org/8055036/<http://codereview.chromium.org/8055...
>

Powered by Google App Engine
This is Rietveld 408576698