Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6256)

Unified Diff: chrome/test/data/webui/print_preview.js

Issue 8055036: Revert 103010 - Refactored code to move cloudprint specific code into print_preview_cloud.js. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/print_preview_handler.cc ('k') | printing/print_job_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/print_preview.js
===================================================================
--- chrome/test/data/webui/print_preview.js (revision 103066)
+++ chrome/test/data/webui/print_preview.js (working copy)
@@ -235,42 +235,48 @@
// Test that the printer list is structured correctly after calling
// addCloudPrinters with an empty list.
-TEST_F('PrintPreviewWebUITest', 'TestPrinterListCloudEmpty', function() {
- cloudprint.addCloudPrinters([], addDestinationListOptionAtPosition);
+TEST_F('PrintPreviewWebUITest', 'FLAKY_TestPrinterListCloudEmpty', function() {
+ addCloudPrinters([]);
var printerList = $('printer-list');
assertNotEquals(null, printerList);
+ expectEquals(localStrings.getString('cloudPrinters'),
+ printerList.options[0].text);
+ expectEquals(localStrings.getString('addCloudPrinter'),
+ printerList.options[1].text);
});
// Test that the printer list is structured correctly after calling
// addCloudPrinters with a null list.
-TEST_F('PrintPreviewWebUITest', 'TestPrinterListCloudNull', function() {
- cloudprint.addCloudPrinters(null, addDestinationListOptionAtPosition);
+TEST_F('PrintPreviewWebUITest', 'FLAKY_TestPrinterListCloudNull', function() {
+ addCloudPrinters(null);
var printerList = $('printer-list');
assertNotEquals(null, printerList);
+ expectEquals(localStrings.getString('cloudPrinters'),
+ printerList.options[0].text);
expectEquals(localStrings.getString('signIn'),
- printerList.options[0].text);
+ printerList.options[1].text);
});
// Test that the printer list is structured correctly after attempting to add
// individual cloud printers until no more can be added.
-TEST_F('PrintPreviewWebUITest', 'TestPrinterListCloud', function() {
+TEST_F('PrintPreviewWebUITest', 'FLAKY_TestPrinterListCloud', function() {
var printerList = $('printer-list');
assertNotEquals(null, printerList);
var printer = new Object;
printer['name'] = 'FooCloud';
for (var i = 0; i < maxCloudPrinters; i++) {
printer['id'] = String(i);
- cloudprint.addCloudPrinters([printer], addDestinationListOptionAtPosition);
- expectEquals('FooCloud', printerList.options[i].text);
- expectEquals(String(i), printerList.options[i].value);
+ addCloudPrinters([printer]);
+ expectEquals(localStrings.getString('cloudPrinters'),
+ printerList.options[0].text);
+ expectEquals('FooCloud', printerList.options[i + 1].text);
+ expectEquals(String(i), printerList.options[i + 1].value);
}
- cloudprint.addCloudPrinters([printer], addDestinationListOptionAtPosition);
- expectNotEquals('FooCloud', printerList.options[i].text);
- expectNotEquals(String(i), printerList.options[i].value);
- for (var i = 0; i < maxCloudPrinters; i++) {
- expectEquals('FooCloud', printerList.options[i].text);
- expectEquals(String(i), printerList.options[i].value);
- }
+ printer['id'] = maxCloudPrinters + 1;
+ addCloudPrinters([printer]);
+ expectEquals('', printerList.options[maxCloudPrinters + 1].text);
+ expectEquals(localStrings.getString('morePrinters'),
+ printerList.options[maxCloudPrinters + 2].text);
});
/**
« no previous file with comments | « chrome/browser/ui/webui/print_preview_handler.cc ('k') | printing/print_job_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698