Add check to debug issue 96063

Add check to debug issue 96063

BUG=96063
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103083

[vandebo (ex-Chrome), 2011-09-27 23:01:08]

PTAL

[Lei Zhang, 2011-09-27 23:07:56]

http://codereview.chromium.org/8054031/diff/1/printing/page_setup.cc
File printing/page_setup.cc (right):

http://codereview.chromium.org/8054031/diff/1/printing/page_setup.cc#newcode123
printing/page_setup.cc:123: CHECK(content_area_.width() > 0 &&
content_area_.height() > 0);
How about doing this as two separate checks so you can see which one failed?

[vandebo (ex-Chrome), 2011-09-27 23:09:44]

http://codereview.chromium.org/8054031/diff/1/printing/page_setup.cc
File printing/page_setup.cc (right):

http://codereview.chromium.org/8054031/diff/1/printing/page_setup.cc#newcode123
printing/page_setup.cc:123: CHECK(content_area_.width() > 0 &&
content_area_.height() > 0);
On 2011/09/27 23:07:56, Lei Zhang wrote:
> How about doing this as two separate checks so you can see which one failed?

I can see which one failed by looking at the minidump.  But, the problem turned
up by the previously added check is that they are both zero.

The check will let me examine the callers to see how they ended up being zero.

[Lei Zhang, 2011-09-27 23:20:06]

LGTM if you believe this is sufficient.

[commit-bot: I haz the power, 2011-09-27 23:24:42]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/vandebo@chromium.org/8054031/1

[commit-bot: I haz the power, 2011-09-28 03:10:56]

Change committed as 103083