Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Unified Diff: printing/page_setup.cc

Issue 8054031: Add check to debug issue 96063 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/page_setup.cc
diff --git a/printing/page_setup.cc b/printing/page_setup.cc
index 9ac3e5203166832ed3f17a0b4652e1f56ef8f64b..46431d836c78add4ecad605987d8c29aac8cdada 100644
--- a/printing/page_setup.cc
+++ b/printing/page_setup.cc
@@ -119,6 +119,8 @@ void PageSetup::Init(const gfx::Size& physical_size,
physical_size.height() -
effective_margins_.bottom -
content_area_.y()));
+ // TODO(vandebo) Remove once bug 96063 is resolved.
+ CHECK(content_area_.width() > 0 && content_area_.height() > 0);
Lei Zhang 2011/09/27 23:07:56 How about doing this as two separate checks so you
vandebo (ex-Chrome) 2011/09/27 23:09:44 I can see which one failed by looking at the minid
}
void PageSetup::SetRequestedMargins(const PageMargins& requested_margins) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698