Recover from bad proxy settings pointing to non-proxy servers that reply anyway.

content/common/net/url_fetcher.cc

Index: content/common/net/url_fetcher.cc
diff --git a/content/common/net/url_fetcher.cc b/content/common/net/url_fetcher.cc
index be4d448eaa6c327b0e7d296e9bf7b827c920bec0..677eafea55a83b79924fa38f23ba42be13576b97 100644
--- a/content/common/net/url_fetcher.cc
+++ b/content/common/net/url_fetcher.cc
@@ -1007,6 +1007,11 @@ net::HttpResponseHeaders* URLFetcher::response_headers() const {
   return core_->response_headers_;
 }
 
+void URLFetcher::set_response_headers(
+    scoped_refptr<net::HttpResponseHeaders> headers) {

[Mattias Nissler (ping if slow), 2011/09/28 09:06:18]

Pass a const ref in order to avoid an unnecessary copy?

I thought we had the general rule to pass a refcounted X to functions as plain
pointers, since the caller needs to hold a reference anyway. Lately, I've seen
more and more code declaring parameters as const scoped_refptr<X>&. Since Will
and Eric are on this review: What's the rule?

[willchan no longer on Chromium, 2011/09/28 18:51:28]

The rule is to pass in a raw pointer, never const scoped_refptr<T>&.

+  core_->response_headers_ = headers;
+}
+
 // TODO(panayiotis): socket_address_ is written in the IO thread,
 // if this is accessed in the UI thread, this could result in a race.
 // Same for response_headers_ above and was_fetched_via_proxy_ below.
@@ -1018,6 +1023,10 @@ bool URLFetcher::was_fetched_via_proxy() const {
   return core_->was_fetched_via_proxy_;
 }
 
+void URLFetcher::set_was_fetched_via_proxy(bool flag) {
+  core_->was_fetched_via_proxy_ = flag;
+}
+
 void URLFetcher::Start() {
   core_->Start();
 }