Recover from bad proxy settings pointing to non-proxy servers that reply anyway.

content/common/net/url_fetcher.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/net/url_fetcher.h"
 
 #include <set>
 
 #include "base/compiler_specific.h"
 #include "base/file_path.h"
@@ skipping 989 matching lines @@
 void URLFetcher::SaveResponseToTemporaryFile(
     scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy) {
   core_->file_message_loop_proxy_ = file_message_loop_proxy;
   core_->response_destination_ = TEMP_FILE;
 }
 
 net::HttpResponseHeaders* URLFetcher::response_headers() const {
   return core_->response_headers_;
 }
 
+void URLFetcher::set_response_headers(
+    scoped_refptr<net::HttpResponseHeaders> headers) {

[Mattias Nissler (ping if slow), 2011/09/28 09:06:18]

Pass a const ref in order to avoid an unnecessary copy?

I thought we had the general rule to pass a refcounted X to functions as plain
pointers, since the caller needs to hold a reference anyway. Lately, I've seen
more and more code declaring parameters as const scoped_refptr<X>&. Since Will
and Eric are on this review: What's the rule?

[willchan no longer on Chromium, 2011/09/28 18:51:28]

The rule is to pass in a raw pointer, never const scoped_refptr<T>&.

+  core_->response_headers_ = headers;
+}
+
 // TODO(panayiotis): socket_address_ is written in the IO thread,
 // if this is accessed in the UI thread, this could result in a race.
 // Same for response_headers_ above and was_fetched_via_proxy_ below.
 net::HostPortPair URLFetcher::socket_address() const {
   return core_->socket_address_;
 }
 
 bool URLFetcher::was_fetched_via_proxy() const {
   return core_->was_fetched_via_proxy_;
 }
 
+void URLFetcher::set_was_fetched_via_proxy(bool flag) {
+  core_->was_fetched_via_proxy_ = flag;
+}
+
 void URLFetcher::Start() {
   core_->Start();
 }
 
 void URLFetcher::StartWithRequestContextGetter(
     net::URLRequestContextGetter* request_context_getter) {
   set_request_context(request_context_getter);
   core_->Start();
 }
 
@@ skipping 83 matching lines @@
 }
 
 // static
 int URLFetcher::GetNumFetcherCores() {
   return Core::g_registry.Get().size();
 }
 
 URLFetcher::Delegate* URLFetcher::delegate() const {
   return core_->delegate();
 }