Issue 8046023: Cleaned up threadiness of BufferedDataSource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8046023: Cleaned up threadiness of BufferedDataSource. (Closed)

Created:
9 years, 2 months ago by Ami GONE FROM CHROMIUM

Modified:
9 years, 2 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, commit-bot: I haz the power

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Cleaned up threadiness of BufferedDataSource. BUG=96292 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103008

Patch Set 1 : . #

Total comments: 1

Patch Set 2 : acolwell CR. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -12 lines)			Patch
	M	webkit/glue/media/buffered_data_source.h	View		3 chunks	+5 lines, -2 lines	0 comments	Download
	M	webkit/glue/media/buffered_data_source.cc	View	1	10 chunks	+37 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

LGTM http://codereview.chromium.org/8046023/diff/4001/webkit/glue/media/buffered_data_source.cc File webkit/glue/media/buffered_data_source.cc (right): http://codereview.chromium.org/8046023/diff/4001/webkit/glue/media/buffered_data_source.cc#newcode659 webkit/glue/media/buffered_data_source.cc:659: // Called from various threads. nit: Add lock_.AssertAcquired() ...

9 years, 2 months ago (2011-09-27 16:57:14 UTC) #2

commit-bot: I haz the power

CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/8046023/4002

9 years, 2 months ago (2011-09-27 18:31:25 UTC) #3

Change committed as 103008

Expand Messages | Collapse Messages