Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1431)

Unified Diff: webkit/glue/media/buffered_data_source.h

Issue 8046023: Cleaned up threadiness of BufferedDataSource. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: acolwell CR. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/glue/media/buffered_data_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/media/buffered_data_source.h
diff --git a/webkit/glue/media/buffered_data_source.h b/webkit/glue/media/buffered_data_source.h
index 4dc3e96174becd2a3c15b6da7ade93e850eda832..fd20e64d0cd01b3ddbb6e9350cf5d1db3b384a5b 100644
--- a/webkit/glue/media/buffered_data_source.h
+++ b/webkit/glue/media/buffered_data_source.h
@@ -20,6 +20,8 @@ class MediaLog;
namespace webkit_glue {
+// This class may be created on any thread, and is callable from the render
+// thread as well as media-specific threads.
class BufferedDataSource : public WebDataSource {
public:
// Creates a DataSourceFactory for building BufferedDataSource objects.
@@ -129,7 +131,7 @@ class BufferedDataSource : public WebDataSource {
// Callback method when a network event is received.
void NetworkEventCallback();
- void UpdateHostState();
+ void UpdateHostState_Locked();
// URL of the resource requested.
GURL url_;
@@ -182,7 +184,8 @@ class BufferedDataSource : public WebDataSource {
// The message loop of the render thread.
MessageLoop* render_loop_;
- // Protects |stopped_|.
+ // Protects |stop_signal_received_|, |stopped_on_render_loop_| and
+ // |initialize_cb_|.
base::Lock lock_;
// Stop signal to suppressing activities. This variable is set on the pipeline
« no previous file with comments | « no previous file | webkit/glue/media/buffered_data_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698