Issue 8046003: Add code comments to deferred code objects to make debugging easier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8046003: Add code comments to deferred code objects to make debugging easier. (Closed)

Created:
9 years, 2 months ago by fschneider

Modified:
9 years, 2 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Add code comments to deferred code objects to make debugging easier. Committed: http://code.google.com/p/v8/source/detail?r=9422

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -39 lines)			Patch
M	src/arm/lithium-codegen-arm.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	10 chunks	+18 lines, -12 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	10 chunks	+20 lines, -12 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	9 chunks	+19 lines, -12 lines	0 comments	Download

Total messages: 2 (0 generated)

Jakob Kummerow

9 years, 2 months ago (2011-09-26 09:11:50 UTC) #2

LGTM if you port the comment generation to the ARM code as well ;-)