Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Side by Side Diff: src/arm/lithium-codegen-arm.h

Issue 8046003: Add code comments to deferred code objects to make debugging easier. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 358 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 friend class LDeferredCode; 369 friend class LDeferredCode;
370 friend class LEnvironment; 370 friend class LEnvironment;
371 friend class SafepointGenerator; 371 friend class SafepointGenerator;
372 DISALLOW_COPY_AND_ASSIGN(LCodeGen); 372 DISALLOW_COPY_AND_ASSIGN(LCodeGen);
373 }; 373 };
374 374
375 375
376 class LDeferredCode: public ZoneObject { 376 class LDeferredCode: public ZoneObject {
377 public: 377 public:
378 explicit LDeferredCode(LCodeGen* codegen) 378 explicit LDeferredCode(LCodeGen* codegen)
379 : codegen_(codegen), external_exit_(NULL) { 379 : codegen_(codegen),
380 external_exit_(NULL),
381 instruction_index_(codegen->current_instruction_) {
380 codegen->AddDeferredCode(this); 382 codegen->AddDeferredCode(this);
381 } 383 }
382 384
383 virtual ~LDeferredCode() { } 385 virtual ~LDeferredCode() { }
384 virtual void Generate() = 0; 386 virtual void Generate() = 0;
387 virtual LInstruction* instr() = 0;
385 388
386 void SetExit(Label *exit) { external_exit_ = exit; } 389 void SetExit(Label *exit) { external_exit_ = exit; }
387 Label* entry() { return &entry_; } 390 Label* entry() { return &entry_; }
388 Label* exit() { return external_exit_ != NULL ? external_exit_ : &exit_; } 391 Label* exit() { return external_exit_ != NULL ? external_exit_ : &exit_; }
392 int instruction_index() const { return instruction_index_; }
389 393
390 protected: 394 protected:
391 LCodeGen* codegen() const { return codegen_; } 395 LCodeGen* codegen() const { return codegen_; }
392 MacroAssembler* masm() const { return codegen_->masm(); } 396 MacroAssembler* masm() const { return codegen_->masm(); }
393 397
394 private: 398 private:
395 LCodeGen* codegen_; 399 LCodeGen* codegen_;
396 Label entry_; 400 Label entry_;
397 Label exit_; 401 Label exit_;
398 Label* external_exit_; 402 Label* external_exit_;
403 int instruction_index_;
399 }; 404 };
400 405
401 } } // namespace v8::internal 406 } } // namespace v8::internal
402 407
403 #endif // V8_ARM_LITHIUM_CODEGEN_ARM_H_ 408 #endif // V8_ARM_LITHIUM_CODEGEN_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698