Issue 8041035: Tighten up assertions checking GC-safety of stub calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8041035: Tighten up assertions checking GC-safety of stub calls. (Closed)

Created:
9 years, 2 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 2 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Tighten up assertions checking GC-safety of stub calls. Ensure that stubs are properly pregenerated on all platforms. R=erik.corry@gmail.com BUG=v8:1729 Committed: http://code.google.com/p/v8/source/detail?r=9447

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -27 lines)			Patch
M	src/arm/code-stubs-arm.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	5 chunks	+8 lines, -3 lines	1 comment	Download
M	src/arm/macro-assembler-arm.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/code-stubs.h	View	2 chunks	+11 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	5 chunks	+15 lines, -4 lines	1 comment	Download
M	src/ia32/macro-assembler-ia32.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/code-stubs-x64.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years, 2 months ago (2011-09-26 22:47:26 UTC) #2

oops
lgtm

http://codereview.chromium.org/8041035/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/8041035/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2097: // Explicitly allow generation of nested stubs.
It is safe here.
Can the comment explain in more detail why this is OK?

http://codereview.chromium.org/8041035/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/8041035/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:6598: // { ebx, edi, edx, EMIT_REMEMBERED_SET },
Commented  code

Expand Messages | Collapse Messages