Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: src/x64/code-stubs-x64.h

Issue 8041035: Tighten up assertions checking GC-safety of stub calls. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 }; 59 };
60 60
61 61
62 class StoreBufferOverflowStub: public CodeStub { 62 class StoreBufferOverflowStub: public CodeStub {
63 public: 63 public:
64 explicit StoreBufferOverflowStub(SaveFPRegsMode save_fp) 64 explicit StoreBufferOverflowStub(SaveFPRegsMode save_fp)
65 : save_doubles_(save_fp) { } 65 : save_doubles_(save_fp) { }
66 66
67 void Generate(MacroAssembler* masm); 67 void Generate(MacroAssembler* masm);
68 68
69 virtual bool CompilingCallsToThisStubIsGCSafe() { return true; } 69 virtual bool IsPregenerated() { return true; }
70 static void GenerateFixedRegStubsAheadOfTime(); 70 static void GenerateFixedRegStubsAheadOfTime();
71 virtual bool SometimesSetsUpAFrame() { return false; } 71 virtual bool SometimesSetsUpAFrame() { return false; }
72 72
73 private: 73 private:
74 SaveFPRegsMode save_doubles_; 74 SaveFPRegsMode save_doubles_;
75 75
76 Major MajorKey() { return StoreBufferOverflow; } 76 Major MajorKey() { return StoreBufferOverflow; }
77 int MinorKey() { return (save_doubles_ == kSaveFPRegs) ? 1 : 0; } 77 int MinorKey() { return (save_doubles_ == kSaveFPRegs) ? 1 : 0; }
78 }; 78 };
79 79
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 address, // An input reg. 490 address, // An input reg.
491 value) { // One scratch reg. 491 value) { // One scratch reg.
492 } 492 }
493 493
494 enum Mode { 494 enum Mode {
495 STORE_BUFFER_ONLY, 495 STORE_BUFFER_ONLY,
496 INCREMENTAL, 496 INCREMENTAL,
497 INCREMENTAL_COMPACTION 497 INCREMENTAL_COMPACTION
498 }; 498 };
499 499
500 virtual bool CompilingCallsToThisStubIsGCSafe(); 500 virtual bool IsPregenerated();
501 static void GenerateFixedRegStubsAheadOfTime(); 501 static void GenerateFixedRegStubsAheadOfTime();
502 virtual bool SometimesSetsUpAFrame() { return false; } 502 virtual bool SometimesSetsUpAFrame() { return false; }
503 503
504 static const byte kTwoByteNopInstruction = 0x3c; // Cmpb al, #imm8. 504 static const byte kTwoByteNopInstruction = 0x3c; // Cmpb al, #imm8.
505 static const byte kTwoByteJumpInstruction = 0xeb; // Jmp #imm8. 505 static const byte kTwoByteJumpInstruction = 0xeb; // Jmp #imm8.
506 506
507 static const byte kFiveByteNopInstruction = 0x3d; // Cmpl eax, #imm32. 507 static const byte kFiveByteNopInstruction = 0x3d; // Cmpl eax, #imm32.
508 static const byte kFiveByteJumpInstruction = 0xe9; // Jmp #imm32. 508 static const byte kFiveByteJumpInstruction = 0xe9; // Jmp #imm32.
509 509
510 static Mode GetMode(Code* stub) { 510 static Mode GetMode(Code* stub) {
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
717 RememberedSetAction remembered_set_action_; 717 RememberedSetAction remembered_set_action_;
718 SaveFPRegsMode save_fp_regs_mode_; 718 SaveFPRegsMode save_fp_regs_mode_;
719 Label slow_; 719 Label slow_;
720 RegisterAllocation regs_; 720 RegisterAllocation regs_;
721 }; 721 };
722 722
723 723
724 } } // namespace v8::internal 724 } } // namespace v8::internal
725 725
726 #endif // V8_X64_CODE_STUBS_X64_H_ 726 #endif // V8_X64_CODE_STUBS_X64_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698