Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 804006: Add a flag to fail if the tests fail to build. Off by default. (Closed)

Created:
10 years, 9 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
kmixter1, sosa
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Add a flag to fail if the tests fail to build. Off by default.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments. #

Total comments: 2

Patch Set 3 : Remove echo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/scripts/build_autotest.sh View 1 2 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
petkov
10 years, 9 months ago (2010-03-11 00:02:07 UTC) #1
sosa
http://codereview.chromium.org/804006/diff/1/2 File src/scripts/build_autotest.sh (right): http://codereview.chromium.org/804006/diff/1/2#newcode76 src/scripts/build_autotest.sh:76: [ $FLAGS_buildcheck -eq "$FLAGS_TRUE" ] && USE="${USE} buildcheck" Could ...
10 years, 9 months ago (2010-03-11 00:06:37 UTC) #2
petkov
PTAL http://codereview.chromium.org/804006/diff/1/2 File src/scripts/build_autotest.sh (right): http://codereview.chromium.org/804006/diff/1/2#newcode76 src/scripts/build_autotest.sh:76: [ $FLAGS_buildcheck -eq "$FLAGS_TRUE" ] && USE="${USE} buildcheck" ...
10 years, 9 months ago (2010-03-11 00:18:33 UTC) #3
sosa
lgtm with nit. Can you remove the echo? I believe the emerge echoes the USE ...
10 years, 9 months ago (2010-03-11 00:21:03 UTC) #4
petkov
10 years, 9 months ago (2010-03-11 00:27:59 UTC) #5
Submitting...

http://codereview.chromium.org/804006/diff/5001/6001
File src/scripts/build_autotest.sh (right):

http://codereview.chromium.org/804006/diff/5001/6001#newcode73
src/scripts/build_autotest.sh:73: echo USE: ${USE}
On 2010/03/11 00:21:03, sosa wrote:
> Nit:  remove debug

I didn't see them but I didn't look carefully. Remove echo anyway.

Powered by Google App Engine
This is Rietveld 408576698