Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: src/scripts/build_autotest.sh

Issue 804006: Add a flag to fail if the tests fail to build. Off by default. (Closed)
Patch Set: Remove echo Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/scripts/build_autotest.sh
diff --git a/src/scripts/build_autotest.sh b/src/scripts/build_autotest.sh
index 98a5029056fdc59352836cada99cf3db076c81ac..393da83b7d1d242700d30b89a9107fa992715bd1 100755
--- a/src/scripts/build_autotest.sh
+++ b/src/scripts/build_autotest.sh
@@ -23,6 +23,7 @@ DEFINE_string build "${DEFAULT_TESTS_LIST}" \
"a comma seperated list of autotest client tests to be prebuilt." b
DEFINE_boolean prompt $FLAGS_TRUE "Prompt user when building all tests."
DEFINE_boolean autox $FLAGS_TRUE "Build autox along with autotest"
+DEFINE_boolean buildcheck $FLAGS_FALSE "Fail if tests fail to build"
# More useful help
FLAGS_HELP="usage: $0 [flags]"
@@ -65,12 +66,10 @@ else
TEST_LIST=${FLAGS_build}
fi
-# Decide whether or not to build autox and set use flag
-if [ $FLAGS_autox -eq "$FLAGS_TRUE" ] ; then
- USE=
-else
- USE=-autox
-fi
+# Decide on USE flags based on options
+USE=
+[ $FLAGS_autox -eq "$FLAGS_FALSE" ] && USE="${USE} -autox"
+[ $FLAGS_buildcheck -eq "$FLAGS_TRUE" ] && USE="${USE} buildcheck"
GCLIENT_ROOT="${GCLIENT_ROOT}" TEST_LIST=${TEST_LIST} FEATURES="-buildpkg" \
USE="$USE" "emerge-${FLAGS_board}" chromeos-base/autotest
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698