Add defensive checks to the flow graph builder.

Add defensive checks to the flow graph builder.

Visitor stack overflow is used to signal an unsupported construct in
the flow graph.  Check for it in more places.  Make the utility
functions for appending to graphs handle more cases if they can be
handled correctly.

Remove the entry node in favor of a block with a NULL predecessor as
single entry.  Represent the empty flow graph as a single empty block.
Add empty blocks lazily where needed to preserve edge-split form.

Committed: http://code.google.com/p/v8/source/detail?r=4086

[fschneider, 2010-03-10 16:51:09]

LGTM.

http://codereview.chromium.org/804003/diff/1/2
File src/compiler.cc (right):

http://codereview.chromium.org/804003/diff/1/2#newcode471
src/compiler.cc:471: if (FLAG_print_graph_text) {
Also check for stack overflow here?

http://codereview.chromium.org/804003/diff/1/3
File src/data-flow.cc (right):

http://codereview.chromium.org/804003/diff/1/3#newcode63
src/data-flow.cc:63: // successors to branch nodes).
Maybe ASSERT(graph != NULL) for consistency with the other AppendX functions,