Add defensive checks to the flow graph builder.

src/compiler.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 66 matching lines @@
     // Signal a stack overflow by returning a null handle.  The stack
     // overflow exception will be thrown by the caller.
     return Handle<Code>::null();
   }
 
   if (FLAG_use_flow_graph) {
     FlowGraphBuilder builder;
     builder.Build(function);
 
 #ifdef DEBUG
-    if (FLAG_print_graph_text) {
+    if (FLAG_print_graph_text && !builder.HasStackOverflow()) {
       builder.graph()->PrintText(builder.postorder());
     }
 #endif
   }
 
   // Generate code and return it.  Code generator selection is governed by
   // which backends are enabled and whether the function is considered
   // run-once code or not:
   //
   //  --full-compiler enables the dedicated backend for code we expect to be
@@ skipping 363 matching lines @@
     // the AST optimizer/analyzer.
     if (!Rewriter::Optimize(literal)) {
       return Handle<JSFunction>::null();
     }
 
     if (FLAG_use_flow_graph) {
       FlowGraphBuilder builder;
       builder.Build(literal);
 
 #ifdef DEBUG
       if (FLAG_print_graph_text) {

[fschneider, 2010/03/10 16:51:09]

Also check for stack overflow here?

         builder.graph()->PrintText(builder.postorder());
       }
 #endif
     }
 
     // Generate code and return it.  The way that the compilation mode
     // is controlled by the command-line flags is described in
     // the static helper function MakeCode.
     CompilationInfo info(literal, script, false);
 
@@ skipping 111 matching lines @@
       LOG(CodeCreateEvent(tag, *code, *func_name));
       OProfileAgent::CreateNativeCodeRegion(*func_name,
                                             code->instruction_start(),
                                             code->instruction_size());
     }
   }
 }
 #endif
 
 } }  // namespace v8::internal