Issue 8038028: Use universal EOL conversion when calling the text editor in gcl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8038028: Use universal EOL conversion when calling the text editor in gcl. (Closed)

Created:
9 years, 2 months ago by M-A Ruel

Modified:
9 years, 2 months ago

Reviewers:
Dirk Pranke, commit-bot: I haz the power

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Use universal EOL conversion when calling the text editor in gcl. This was causing issues for windows user with notepad2. Fix trychange.py on python2.5. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102797

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	gcl.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	presubmit_support.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/gcl_unittest.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8038028/1

9 years, 2 months ago (2011-09-26 20:58:40 UTC) #3

Change committed as 102797