Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: gcl.py

Issue 8038028: Use universal EOL conversion when calling the text editor in gcl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | presubmit_support.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
diff --git a/gcl.py b/gcl.py
index 0c8fbb61ef35a255dbfebb69d0bc36baae048320..dffc566330e5934fb9e0ea87eb12141dfd1d9c8f 100755
--- a/gcl.py
+++ b/gcl.py
@@ -532,7 +532,7 @@ class ChangeInfo(object):
if fail_on_not_found:
ErrorExit("Changelist " + changename + " not found.")
return ChangeInfo(changename, 0, 0, '', None, local_root, None, False)
- content = gclient_utils.FileRead(info_file, 'r')
+ content = gclient_utils.FileRead(info_file)
save = False
try:
values = ChangeInfo._LoadNewFormat(content)
@@ -1137,7 +1137,7 @@ def CMDchange(args):
subprocess2.check_call(cmd, shell=True)
except subprocess2.CalledProcessError, e:
ErrorExit('Editor returned %d' % e.returncode)
- result = gclient_utils.FileRead(filename, 'r')
+ result = gclient_utils.FileRead(filename)
finally:
os.remove(filename)
« no previous file with comments | « no previous file | presubmit_support.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698