Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: webkit/glue/web_intent_service_data.cc

Issue 8028006: Fixed nits from move of web_intent_service_data.* to webkit/glue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/glue/web_intent_service_data.h ('k') | webkit/glue/webkit_glue.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <ostream> 5 #include <ostream>
6 6
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "webkit/glue/web_intent_service_data.h" 8 #include "webkit/glue/web_intent_service_data.h"
9 9
10 WebIntentServiceData::WebIntentServiceData() 10 WebIntentServiceData::WebIntentServiceData()
11 : disposition(WebIntentServiceData::DISPOSITION_WINDOW) { 11 : disposition(WebIntentServiceData::DISPOSITION_WINDOW) {
12 } 12 }
13 13
14 WebIntentServiceData::~WebIntentServiceData() {} 14 WebIntentServiceData::~WebIntentServiceData() {}
15 15
16 bool WebIntentServiceData::operator==(const WebIntentServiceData& other) const { 16 bool WebIntentServiceData::operator==(const WebIntentServiceData& other) const {
17 return (service_url == other.service_url && 17 return service_url == other.service_url &&
18 action == other.action && 18 action == other.action &&
tony 2011/09/23 22:39:13 Nit: These should probably be indented 4 spaces fr
groby-ooo-7-16 2011/09/23 22:48:54 According to style guideline, it's only "indent 4"
19 type == other.type && 19 type == other.type &&
20 title == other.title && 20 title == other.title &&
21 disposition == other.disposition); 21 disposition == other.disposition;
22 } 22 }
23 23
24 std::ostream& operator<<(::std::ostream& os, 24 std::ostream& operator<<(::std::ostream& os,
25 const WebIntentServiceData& intent) { 25 const WebIntentServiceData& intent) {
26 return os << 26 return os <<
27 "{" << intent.service_url << 27 "{" << intent.service_url <<
28 ", " << UTF16ToUTF8(intent.action) << 28 ", " << UTF16ToUTF8(intent.action) <<
29 ", " << UTF16ToUTF8(intent.type) << 29 ", " << UTF16ToUTF8(intent.type) <<
30 ", " << UTF16ToUTF8(intent.title) << 30 ", " << UTF16ToUTF8(intent.title) <<
31 ", " << intent.disposition << 31 ", " << intent.disposition <<
32 "}"; 32 "}";
33 } 33 }
OLDNEW
« no previous file with comments | « webkit/glue/web_intent_service_data.h ('k') | webkit/glue/webkit_glue.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698