Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3661)

Unified Diff: chrome/browser/web_resource/promo_resource_service.cc

Issue 8008021: Add new UMA stats to get a handle on Downloads UI Usage (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: fixed tests Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_resource/promo_resource_service.cc
diff --git a/chrome/browser/web_resource/promo_resource_service.cc b/chrome/browser/web_resource/promo_resource_service.cc
index 7b62757bbe66abedf4c8fceb3165a2f622d7826e..5ee1cff4d476e6442570d53d06e694b1f167be54 100644
--- a/chrome/browser/web_resource/promo_resource_service.cc
+++ b/chrome/browser/web_resource/promo_resource_service.cc
@@ -296,7 +296,8 @@ void PromoResourceService::SetNotificationParams(DictionaryValue* a_dic) {
max_group < 0 ||
max_group >= kNTPPromoGroupSize) {
// If values are not valid, do not show promo.
- NOTREACHED() << "Invalid server data, question=" << question <<
+ LOG(ERROR) << "Invalid server data, question=" << question <<
+ ", err=" << err <<
Randy Smith (Not in Mondays) 2011/09/30 15:57:21 What's the context for this change?
benjhayden 2011/10/03 20:54:39 I reached the NOTREACHED, but this file changed dr
", build=" << promo_build <<
", time_slice=" << time_slice <<
", max_group=" << max_group;

Powered by Google App Engine
This is Rietveld 408576698