Add new UMA stats to get a handle on Downloads UI Usage

chrome/browser/web_resource/promo_resource_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/web_resource/promo_resource_service.h"
 
 #include "base/command_line.h"
 #include "base/string_number_conversions.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/time.h"
@@ skipping 278 matching lines @@
   int max_group = GetNextQuestionValue(question, &index, &err);
 
   if (err ||
       promo_build < 0 ||
       promo_build > ALL_BUILDS ||
       time_slice < 0 ||
       time_slice > kMaxTimeSliceHours ||
       max_group < 0 ||
       max_group >= kNTPPromoGroupSize) {
     // If values are not valid, do not show promo.
-    NOTREACHED() << "Invalid server data, question=" << question <<
+    LOG(ERROR) << "Invalid server data, question=" << question <<
+        ", err=" << err <<

[Randy Smith (Not in Mondays), 2011/09/30 15:57:21]

What's the context for this change?

[benjhayden, 2011/10/03 20:54:39]

I reached the NOTREACHED, but this file changed dramatically in today's merge
and I'm not reaching the NOTREACHED anymore.

         ", build=" << promo_build <<
         ", time_slice=" << time_slice <<
         ", max_group=" << max_group;
     promo_build = NO_BUILD;
     time_slice = 0;
     max_group = 0;
   }
 
   prefs_->SetInteger(prefs::kNTPPromoBuild, promo_build);
   prefs_->SetInteger(prefs::kNTPPromoGroupTimeSlice, time_slice);
@@ skipping 267 matching lines @@
   if (!(old_logo_start == logo_start) ||
       !(old_logo_end == logo_end)) {
     prefs_->SetDouble(prefs::kNTPCustomLogoStart, logo_start);
     prefs_->SetDouble(prefs::kNTPCustomLogoEnd, logo_end);
     NotificationService* service = NotificationService::current();
     service->Notify(chrome::NOTIFICATION_PROMO_RESOURCE_STATE_CHANGED,
                     Source<WebResourceService>(this),
                     NotificationService::NoDetails());
   }
 }