Change default on Mac to use_skia=1

Change default on Mac to use_skia=1

For context, see http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/f8d4f43b6e66ab83#
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102532

[epoger, 2011-09-23 14:20:31]

I don't see how any of the trybot failures could be a result of this change. 
Ignoring them.

[epoger, 2011-09-23 15:20:44]

This CL may cause locally-run layout_tests to fail unless you also pick up the
Webkit CL described at https://bugs.webkit.org/show_bug.cgi?id=68698 .  That CL
changes the default Mac port from chromium-cg-mac to chromium-mac.

(The production chromium.webkit bots should stay green, though, because they
already explicitly run against chromium-cg-mac or chromium-mac ports.)

[Mihai Parparita -not on Chrome, 2011-09-23 15:55:20]

http://codereview.chromium.org/8002009/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/8002009/diff/1/build/common.gypi#newcode211
build/common.gypi:211: # TODO(epoger): Figure out how to set use_skia=1 for Mac
outside of
When you tried to move out out of the conditions block, did you also remove the
copying done at line 309?

[epoger, 2011-09-23 16:03:35]

On 2011/09/23 15:55:20, Mihai Parparita wrote:
> http://codereview.chromium.org/8002009/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
> http://codereview.chromium.org/8002009/diff/1/build/common.gypi#newcode211
> build/common.gypi:211: # TODO(epoger): Figure out how to set use_skia=1 for
Mac
> outside of
> When you tried to move out out of the conditions block, did you also remove
the
> copying done at line 309?

No, I didn't try that yet.  I doubt that would help, since enable_webrtc is
similarly copied at line 331 and yet still (apparently) can get a
non-conditional setting at line 208.

I ran all kinds of tests yesterday and this was the only arrangement I was able
to get consistently working... if it's OK with you, I would like to commit this
as-is (since it is known to work and I am under pressure to get the default
behavior changed today) and then I can come up with a cleaner fix next week.

[Mihai Parparita -not on Chrome, 2011-09-23 18:12:50]

lgtm