Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: build/common.gypi

Issue 8002009: Change default on Mac to use_skia=1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 102353)
+++ build/common.gypi (working copy)
@@ -208,8 +208,11 @@
'enable_webrtc%': 1,
'conditions': [
+ # TODO(epoger): Figure out how to set use_skia=1 for Mac outside of
Mihai Parparita -not on Chrome 2011/09/23 15:55:20 When you tried to move out out of the conditions b
+ # the 'conditions' clause. Initial attempts resulted in chromium and
+ # webkit disagreeing on its setting.
['OS=="mac"', {
- 'use_skia%': 0,
+ 'use_skia%': 1,
# Mac uses clang by default, so turn on the plugin as well.
'clang_use_chrome_plugins%': 1,
}, {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698