Add comment for fix to issue 95619

Add comment for fix to issue 95619

The fix is very subtle.  We need the comment to ensure we don't accidentally
revert the fix.  It's also a helpful reminder that we should try to find a less
brittle solution.

BUG=95619
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102436

[rlarocque, 2011-09-22 19:07:11]

This change picks up where http://codereview.chromium.org/7847010/ left off. 
See the referenced bug for more details.

[akalin, 2011-09-22 19:13:46]

http://codereview.chromium.org/7995015/diff/1/chrome/browser/sync/profile_syn...
File chrome/browser/sync/profile_sync_service_harness.cc (right):

http://codereview.chromium.org/7995015/diff/1/chrome/browser/sync/profile_syn...
chrome/browser/sync/profile_sync_service_harness.cc:1008: // TODO(rlarocque):
The correctness of this if condition depends on the
It's not clear what the TODO is.  Suggest:

// The correctness ... See crbug.com/95619.
// TODO(rlarocque): Figure out a less brittle way of detecting this.

[rlarocque, 2011-09-22 19:21:38]

That suggestion works for me.  Fixed.

http://codereview.chromium.org/7995015/diff/1/chrome/browser/sync/profile_syn...
File chrome/browser/sync/profile_sync_service_harness.cc (right):

http://codereview.chromium.org/7995015/diff/1/chrome/browser/sync/profile_syn...
chrome/browser/sync/profile_sync_service_harness.cc:1008: // TODO(rlarocque):
The correctness of this if condition depends on the
On 2011/09/22 19:13:47, akalin wrote:
> It's not clear what the TODO is.  Suggest:
> 
> // The correctness ... See crbug.com/95619.
> // TODO(rlarocque): Figure out a less brittle way of detecting this.

Done.

[akalin, 2011-09-22 19:22:08]

LGTM

[commit-bot: I haz the power, 2011-09-22 20:25:15]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/7995015/4002

[commit-bot: I haz the power, 2011-09-23 00:01:04]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 102397, job name
was 7995015-4002 (retry) (previous was lost) (previous was lost) (retry).

[commit-bot: I haz the power, 2011-09-23 01:23:51]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/7995015/4002

[commit-bot: I haz the power, 2011-09-23 03:28:04]

Change committed as 102436