Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: chrome/browser/sync/profile_sync_service_harness.cc

Issue 7995015: Add comment for fix to issue 95619 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Better comment (for real this time) Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service_harness.cc
diff --git a/chrome/browser/sync/profile_sync_service_harness.cc b/chrome/browser/sync/profile_sync_service_harness.cc
index 1caa66d841eb83e336652f74078a69cad612db26..f296f97747661e28a3c8b1cbda1f7490684e251d 100644
--- a/chrome/browser/sync/profile_sync_service_harness.cc
+++ b/chrome/browser/sync/profile_sync_service_harness.cc
@@ -1005,6 +1005,9 @@ bool ProfileSyncServiceHarness::EnableEncryptionForType(
bool ProfileSyncServiceHarness::WaitForTypeEncryption(
syncable::ModelType type) {
+ // The correctness of this if condition depends on the ordering of its
+ // sub-expressions. See crbug.com/95619.
+ // TODO(rlarocque): Figure out a less brittle way of detecting this.
if (IsTypeEncrypted(type) &&
IsSynced() &&
GetLastSessionSnapshot()->num_conflicting_updates == 0) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698