Issue 7995003: Don't take heap snapshot when doing Heap::RecordStats from OOM cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7995003: Don't take heap snapshot when doing Heap::RecordStats from OOM cases. (Closed)

Created:
9 years, 3 months ago by Rico

Modified:
9 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Don't take heap snapshot when doing Heap::RecordStats from OOM cases. Filled issue 1718 to track this. Committed: http://code.google.com/p/v8/source/detail?r=9397

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/api.cc	View	1	1 chunk	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years, 3 months ago (2011-09-22 14:40:38 UTC) #2

LGTM

http://codereview.chromium.org/7995003/diff/3001/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/7995003/diff/3001/src/api.cc#newcode190
src/api.cc:190: // gc.
comment is not precise: we support it, but you need to do a special GC before
using it.

Expand Messages | Collapse Messages