src/api.cc - Issue 7995003: Don't take heap snapshot when doing Heap::RecordStats from OOM cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 7995003: Don't take heap snapshot when doing Heap::RecordStats from OOM cases. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

===================================================================

--- src/api.cc (revision 9396)

+++ src/api.cc (working copy)

@@ -185,7 +185,10 @@

int end_marker;

heap_stats.end_marker = &end_marker;

i::Isolate* isolate = i::Isolate::Current();

- isolate->heap()->RecordStats(&heap_stats, take_snapshot);

+ // BUG(1718):

+ // Don't use the take_snapshot since we don't support HeapIterator in new

+ // gc.

Vyacheslav Egorov (Chromium) 2011/09/22 14:40:38 comment is not precise: we support it, but you nee

+ isolate->heap()->RecordStats(&heap_stats, false);

i::V8::SetFatalError();

FatalErrorCallback callback = GetFatalErrorHandler();

{

« no previous file with comments | « no previous file | no next file » | no next file with comments »