Issue 7991002: I can't count. Fix -Q values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7991002: I can't count. Fix -Q values. (Closed)

Created:
9 years, 3 months ago by M-A Ruel

Modified:
9 years, 3 months ago

Reviewers:
Dirk Pranke, Peter Mayo, commit-bot: I haz the power

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

I can't count. Fix -Q values. Add more doc. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102328

Patch Set 1 #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -13 lines)			Patch
	M	my_reviews.py	View		2 chunks	+32 lines, -13 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Peter, can you review it, I'd like to announce the tool today.

9 years, 3 months ago (2011-09-22 17:42:28 UTC) #2

Peter Mayo

LGTM http://codereview.chromium.org/7991002/diff/1/my_reviews.py File my_reviews.py (right): http://codereview.chromium.org/7991002/diff/1/my_reviews.py#newcode65 my_reviews.py:65: month = today.month - (today.month % 3) + ...

9 years, 3 months ago (2011-09-22 18:56:07 UTC) #3

commit-bot: I haz the power

CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/maruel%40chromium.org/7991002/1

9 years, 3 months ago (2011-09-22 19:08:41 UTC) #4

Change committed as 102328

Expand Messages | Collapse Messages