I can't count. Fix -Q values.

my_reviews.py

 #!/usr/bin/env python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Get rietveld stats.
 
 Example:
   - my_reviews.py -o me@chromium.org -Q  for stats for last quarter.
 """
@@ skipping 44 matching lines @@
       keys_only=False)))
 
 
 def get_previous_quarter(today):
   """There are four quarters, 01-03, 04-06, 07-09, 10-12.
 
   If today is in the last month of a quarter, assume it's the current quarter
   that is requested.
   """
   year = today.year
-  month = today.month - (today.month % 3)
-  if not month:
-    month = 12
+  month = today.month - (today.month % 3) + 1

[Peter Mayo, 2011/09/22 18:56:07]

I would call these begin&end rather than blank and previous, but that would be
better in a separate CL.

+  if month <= 0:
+    month += 12
     year -= 1
-  previous_month = month - 2
+  if month > 12:
+    month -= 12
+    year += 1
+  previous_month = month - 3
+  previous_year = year
+  if previous_month <= 0:
+    previous_month += 12
+    previous_year -= 1
   return (
-      '%d-%02d-01' % (year, previous_month),
+      '%d-%02d-01' % (previous_year, previous_month),
       '%d-%02d-01' % (year, month))
 
 
 def main():
   # Silence upload.py.
   rietveld.upload.verbosity = 0
+  today = datetime.date.today()
+  created_after, created_before = get_previous_quarter(today)
   parser = optparse.OptionParser(description=sys.modules[__name__].__doc__)
   parser.add_option(
       '--count', action='store_true',
       help='Just count instead of printing individual issues')
-  parser.add_option('-o', '--owner')
-  parser.add_option('-r', '--reviewer')
-  parser.add_option('-c', '--created_after')
-  parser.add_option('-C', '--created_before')
+  parser.add_option(
+      '-o', '--owner', metavar='<email>', help='Filter on issue owner')
+  parser.add_option(
+      '-r', '--reviewer', metavar='<email>', help='Filter on issue reviewer')
+  parser.add_option(
+      '-c', '--created_after', metavar='<date>',
+      help='Filter issues created after the date')
+  parser.add_option(
+      '-C', '--created_before', metavar='<date>',
+      help='Filter issues create before the date')
   parser.add_option(
       '-Q', '--last_quarter', action='store_true',
-      help='Use last quarter\'s dates as filter')
-  parser.add_option('-i', '--instance_url', default='codereview.chromium.org')
+      help='Use last quarter\'s dates, e.g. %s to %s' % (
+        created_after, created_before))
+  parser.add_option(
+      '-i', '--instance_url', metavar='<host>',
+      default='http://codereview.chromium.org',
+      help='Host to use, default is %default')
   # Remove description formatting
   parser.format_description = lambda x: parser.description
   options, args = parser.parse_args()
   if args:
     parser.error('Args unsupported')
   if not options.owner and not options.reviewer:
     options.owner = os.environ['EMAIL_ADDRESS']
     if '@' not in options.owner:
       parser.error('Please specify at least -o or -r')
     print >> sys.stderr, 'Defaulting to owner=%s' % options.owner
   if options.last_quarter:
-    today = datetime.date.today()
-    options.created_after, options.created_before = get_previous_quarter(today)
+    options.created_after = created_after
+    options.created_before = created_before
     print >> sys.stderr, 'Using range %s to %s' % (
         options.created_after, options.created_before)
   if options.count:
     print_count(
         options.owner, options.reviewer,
         options.created_after, options.created_before,
         options.instance_url)
   else:
     print_reviews(
         options.owner, options.reviewer,
         options.created_after, options.created_before,
         options.instance_url)
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main())